Re: [whatwg/streams] Merge WritableStreamFinishClose() into WritableStreamDefaultControllerProcessClose() (#640)

Oops. This is violating the design principle. WritableStreamFinishClose() is encapsulating the algorithm for modifying the state of the stream in response to signal from the controller. So, rather than merging WritableStreamFinishClose() into WritableStreamDefaultControllerProcessClose(), the steps in the rejection callback should be factored out and placed next to WritableStreamFinishClose(). I'll rewrite the patch.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/640#issuecomment-270841419

Received on Friday, 6 January 2017 06:31:23 UTC