Re: [whatwg/streams] Add brand checks to TransformStream tests (#772)

domenic approved this pull request.



> +}
+
+test(() => {
+  getterThrowsForAll(TransformStream.prototype, 'readable',
+                     [fakeTS(), realTSDefaultController(), undefined, null]);
+}, 'TransformStream.prototype.readable enforces a brand check');
+
+test(() => {
+  getterThrowsForAll(TransformStream.prototype, 'writable',
+                     [fakeTS(), realTSDefaultController(), undefined, null]);
+}, 'TransformStream.prototype.writable enforces a brand check');
+
+test(() => {
+  constructorThrowsForAll(TransformStreamDefaultController,
+                          [fakeTS(), realTS(), realTSDefaultController(), undefined, null]);
+}, 'TransformStreamDefaultConstructor enforces a brand check and doesn\'t permit independant construction');

Nit: "independ*e*nt". (I have trouble with this a lot so I imagine you probably copied this from a typo I made elsewhere.)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/772#pullrequestreview-57969844

Received on Wednesday, 23 August 2017 04:17:30 UTC