Re: [whatwg/fullscreen] Update fullscreen spec to be Shadow DOM compliant (#54)

TakayoshiKochi commented on this pull request.



>  <p>The <dfn attribute for=Document><code>fullscreen</code></dfn> attribute's getter must return
 false if <a>context object</a>'s <a>fullscreen element</a> is null, and true otherwise.
 
 <p class=note>Use
-<a attribute for=Document lt=fullscreenElement><code>document.fullscreenElement</code></a> instead.
+<a attribute for=DocumentOrShadowRoot lt=fullscreenElement><code>document.fullscreenElement</code></a>
+instead.
+
+<p>The <dfn attribute for=DocumentOrShadowRoot><code>fullscreenElement</code></dfn> attribute's
+getter must return the result of <a>retargeting</a> <a>context object</a>'s

Thanks for the comment.
As you suggested, if I make changes to the "fullscreen element" definition, it will change
other places as well and it makes the spec more complicated.
So I'd stay with the current definition of "fullscreen element" and make adjustments at
`DocumentOrShadowRoot.fullscreenElement` API.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/fullscreen/pull/54

Received on Tuesday, 20 September 2016 09:51:11 UTC