Re: [w3c/push-api] Properly defining `pushsubscriptionchange` (#228)

A couple comments:

>From the proposed API, apps won't be able to tell why the event was triggered.  When the "newSubscription" is null, the apps might attempt to request for a new subscription again.  In case a user revokes the permission or the UA revokes the subscription due to violation of the userVisibleOnly setting, it might not be desirable for the user to see a user permission prompt right away.  It'd be nice to at least include a note to recommend checking the permissionState.  Meanwhile, the UA should have some flexibility in firing the event in scenario (2).  For example, clearing notification permissions for all sites is fairly close to clearing browsing history from the user experience perspective. 

In addition, Re scenario (1), should the event also be fired when the oldSubscription actually expires, maybe with oldSubscription set to "null"?  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/w3c/push-api/issues/228#issuecomment-263353869

Received on Monday, 28 November 2016 18:35:28 UTC