Re: [whatwg/streams] "Set totalSize to totalSize + pair.[[size]]." (#582)

Thanks @isonmad, I hadn't noticed that byte queues already do the right thing. It doesn't seem like we're gaining much in terms of readability by doing the wrong thing for non-byte queues.

The reference implementation tracks the size by adding a `.totalSize` attribute to the Array holding the queue. We can't standardise that. The Chrome implementation uses a separate [[queueSize]] internal slot on the controller, which works, but I got confused between queue _size_ and queue _length_ when I was implementing it. I think we need a different name.

The [[totalQueuedBytes]] name used by byte queues is also unsuitable, but maybe [[totalQueuedSize]] is clear enough.

Bikeshedding welcome.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/582#issuecomment-257475305

Received on Tuesday, 1 November 2016 02:27:13 UTC