Re: [whatwg/streams] Mostly-editorial tweaks to align with newer ES algorithm styles (#444) from Takeshi Yoshino on 2016-05-09 (public-webapps-github@w3.org from May 2016)

From: Takeshi Yoshino <notifications@github.com>
Date: Mon, 09 May 2016 00:15:08 -0700
To: whatwg/streams <streams@noreply.github.com>
Cc:
Message-ID: <whatwg/streams/pull/444/c217791963@github.com>

Thanks!

Reviewed from ReadableByteStreamControllerRespond to the bottom. Looks good with some minor issues.

- PromiseInvokeOrNoop in PromiseInvokeOrFallbackOrNoop should be annotated with !, not ?.
- ReadableByteStreamControllerRespondInternal in ReadableByteStreamControllerRespondWithNewView is annotated with ? because of possible abrupt in buffer cloning? Then, return is better than perform? I'm fine with the current combination but wanna make sure that it's intentional.
- The same about ReadableByteStreamControllerRespondInReadableState call in ReadableByteStreamControllerRespondInternal
- CloneArrayBuffer() is taking 4 arguments while even https://tc39.github.io/ecma262/2016/#sec-clonearraybuffer has up to 3 args. What should I look at?

Feel free to land it.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/444#issuecomment-217791963

Received on Monday, 9 May 2016 07:15:39 UTC