Re: [ServiceWorker] What is the "Doom Installing Worker" algorithm supposed to be doing? (#847)

> When Doom Installing Worker is called from Schedule Job it is of course different, as that can happen at any point while another job is installing a worker.

Hmm, yea.  "Sorry I missed where you pointed out it ran from Schedule Job."

That being said, though, it just doesn't seem safe to me.  The various algorithms don't seem designed to account for the idea that their job is going to get "Finish Job" run on it while they are in the middle some async step.

Assuming we really want this optimization I think it would be better for the algorithms to explicitly check for this cancellation at specific checkpoints.

It doesn't seem particularly perf sensitive, though, so I don't plan to implement "Doom Installing Worker" in gecko.  I'm just going to let the jobs run their course for now.

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/slightlyoff/ServiceWorker/issues/847#issuecomment-197026681