Re: [dom] Issue #156. Add legacy event type check to invoke algorithm. (#158)

> +      strings in the first column in the following table, set <var>event</var>'s {{Event/type}}
> +      attribute value to the string in the second column on the same row as the matching string:
> +
> +      <table>
> +       <thead>
> +        <tr><th>Event Type<th>Legacy Event Type
> +       <tbody>
> +        <tr><td>"<code>animationend</code>"<td>"<code>webkitAnimationEnd</code>"
> +        <tr><td>"<code>animationiteration</code>"<td>"<code>webkitAnimationIteration</code>"
> +        <tr><td>"<code>animationstart</code>"<td>"<code>webkitAnimationStart</code>"
> +        <tr><td>"<code>transitionend</code>"<td>"<code>webkitTransitionEnd</code>"
> +      </table>
> +
> +     <li><p>If <var>event</var>'s {{Event/type}} attribute value is <var>listener</var>'s
> +     <b>type</b>, continue, else terminate these substeps (and run them for the next
> +     <a>event listener</a>).

This logic seems wrong. There's a minor problem with "continue" not being a thing, but you could fix that by inverting the if logic. The bigger problem is that if you terminate the substeps, event's type will still be set to the new value, which might be incorrect for the next event listener.

It seems that whenever you terminate these substeps (and this happens not just here, but also later), event's type needs to be set back to the original event type.

Am I missing something?

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/dom/pull/158/files#r52565536