Re: [whatwg/streams] Align WritableStream structure with ReadableStream structure (#488)

> +    return false;
> +  }
> +
> +  return true;
> +}
> +
> +function WritableStreamAbort(stream, reason) {
> +  const state = stream._state;
> +  if (state === 'closed') {
> +    return Promise.resolve(undefined);
> +  }
> +  if (state === 'errored') {
> +    return Promise.reject(stream._storedError);
> +  }
> +
> +  assert(state === 'writable' || state === 'waiting' || state === 'closing');

Basically my concern is with keeping multiple pieces of information coordinated. For example maybe what we want here is to check if the ready promise exists (or to make WritableStreamDefaultWriterReadyPromiseResolve do nothing if it doesn't exist).

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/488/files/dfa07172203b4c292cfb5a3fc88e821a1db7c3db#r72937926

Received on Monday, 1 August 2016 08:07:52 UTC