Re: [streams] Readable byte streams should support an internal queue (#353)

>> PullFromReadableByteStreamInto

> This would be a bit clearer if 2.c was nested under 2.b IMO.

Right. It's a bug. Will fix.

>> RespondToReadableByteStreamByobReaderReadIntoRequest

> I think it needs to do transfers before giving back chunk

Yeah, but should we automatically transfer it in library code than asking underlying source implementors to do it by themselves if necessary?

>> If reader@[[readIntoRequests]] is empty, DetachReadableByteStreamReader(stream).

> Why? Doesn't this lead to situations where you call .read(view) once and then all of a sudden your reader is no longer active? I am probably missing something.

Sorry I cannot get what situation you're concerned with.

Both in ReleaseReadableByteStreamReader and RespondToReadableByteStreamByobReaderReadIntoRequest, this step is invoked only when the stream is in "closed" or "errored" state. read(view) and read() issued after after detaching will be taken care of by the reader object.

---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/issues/353#issuecomment-106802138

Received on Friday, 29 May 2015 13:27:59 UTC