- From: Takeshi Yoshino <notifications@github.com>
- Date: Wed, 01 Jul 2015 07:31:12 -0700
- To: whatwg/streams <streams@noreply.github.com>
Received on Wednesday, 1 July 2015 14:31:39 UTC
> + if (controller._totalQueuedBytes === 0) {
> + // TODO: Detach buffer.
> + controller._pendingPullIntos.push(pullIntoDescriptor);
> +
> + if (controller._insideUnderlyingByteSource) {
> + controller._callPullOrPullIntoLaterIfNeeded = true;
> + return;
> + }
> +
> + CallPullInto(controller);
> + CallPullOrPullIntoRepeatedlyIfNeeded(controller);
> +
> + return;
> + }
> +
> + const ready = FillPullIntoDescriptorFromQueue(controller, pullIntoDescriptor);
We could. I've written these functions separately for each context than an all-in-one function that switches its behavior by checking various conditions, and it turned out it's easier to code.
I've moved asserts to simplify the code a little on a4f9a2848ce5d70725a56a7d61ec2e521c903336
---
Reply to this email directly or view it on GitHub:
https://github.com/whatwg/streams/pull/361/files#r33683605
Received on Wednesday, 1 July 2015 14:31:39 UTC