[Bug 22054] [Custom]: A couple of comments on document.register

https://www.w3.org/Bugs/Public/show_bug.cgi?id=22054

Dimitri Glazkov <dglazkov@chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Dimitri Glazkov <dglazkov@chromium.org> ---
(In reply to comment #0)
> There are a couple of things that I noticed in the new document.register
> implementation in the spec.
> 
>     If NAME is an invalid custom element name, throw an
> InvalidCharacterError and stop.
> 
> The check for an "invalid custom element name" involves comparing it to a
> few known element names but in an HTML document we lowercase NAME after
> dealing with PROTOTYPE. The spec probably has to lowercase NAME here and
> TYPE later to get case-sensitivity correct.

Thanks! I don't need to do anything with TYPE, since it's either NAME or
localName of BASE, which will already have the correct case.
https://dvcs.w3.org/hg/webcomponents/rev/08b3fd017d6e

> 
>         Let INTERFACE be PROTOTYPE's interface
> 
> This means that we should walk PROTOTYPE's prototype chain, looking for an
> object with an interface, right?

No, it's just is a weird construct that appeases Web IDL. The interface is just
a logical construct, which represents the object's properties and methods as a
Web IDL thing: http://www.w3.org/TR/WebIDL/#dfn-interface

It's a no-op from the implementation perspective. I need it to rely on Web
IDL's meaning of "inherits", etc.

> 
>         Let BASE be INTERFACE's inherited interface that is nearest to BASE
> in the prototype chain and that is an element interface
> 
> This defines BASE recursively. This should probably read:
> 
>         Let BASE be INTERFACE's inherited interface that is nearest to
> PROTOTYPE in the prototype chain and that is an element interface
> 
> (note the second instance of BASE has been changed to PROTOTYPE).

Thank you! Fixed it as part of
https://dvcs.w3.org/hg/webcomponents/rev/ea07a8c6329c.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.

Received on Wednesday, 22 May 2013 21:41:39 UTC