Re: [css-flexbox-1-tests] [css-flexbox-1] Add a test for definite cross sizes (#5282)

Originally posted as https://github.com/w3c/csswg-test/pull/1057#issuecomment-193500512 by @dholbert on 07 Mar 2016, 23:19 UTC:

> This testcase doesn't seem to set `display:flex` on anything, so I think it might not be testing what you want it to test... Right now it has:
> 
> ```
>  .flexbox {
>   width: 50px;
>   outline: 3px solid black;
> }
> ```
> 
> I expect you want to have `display:flex` in there?
> 
> Also, might be worth giving all of the flex items all `min-height:0`, so that there's no chance of spuriously "passing" a piece of the test simply because we're stopping a flex item from shrinking below its intrinsic minimum size.



View on GitHub: https://github.com/w3c/web-platform-tests/pull/5282#issuecomment-290706346

Received on Friday, 31 March 2017 13:04:48 UTC