- From: csswg-test-issue-mover <web-platform-tests-notifications@w3.org>
- Date: Fri, 31 Mar 2017 13:11:25 GMT
- To: public-web-platform-tests-notifications@w3.org
Originally posted as https://github.com/w3c/csswg-test/pull/1196#issuecomment-289191564 by @fantasai on 25 Mar 2017, 06:02 UTC: > So, my initial set of comments here is that most of your tests are optimized to make a green square at a great cost to understandability. It's definitely nice to share common references. Going a little out of your way to do so is fine. But making a test so convoluted that it is 10x more difficult to understand is not an acceptable cost to doing so. Please re-review your green square tests and rewrite as needed. > > A few comments on the non-square tests: > * 019 says “are selected” ... there are two things to check here -- one is whether they appear highlighted, the other is whether they will copy when a copy command is initiated. You need to check both, explicitly. > * 021 needs shorter text, as it currently overflows (due to scrollbars taking up space). I would recommend merely using the word PASS, which is traditional for such things, and using a left margin instead of space characters to ensure that the word PASS is positioned “offscreen”. > * 018 is a pretty good test, but I'm finding it quite difficult in Firefox to actually select everything in the box. It seems to work if I select from above+left of the top left corner to below+right of the bottom right corner, but as there isn't much space for the cursor there without running into other pieces of the test (like the textarea), I'd suggest increasing the margin/border/padding to make that easier. Insufficient scope in the selection drag results in copying out pieces of the elided text rather than the whole thing. Alternately maybe that qualifies as a fail. I'm not sure. View on GitHub: https://github.com/w3c/web-platform-tests/pull/5285#issuecomment-290707878
Received on Friday, 31 March 2017 13:11:43 UTC