- From: csswg-test-issue-mover <web-platform-tests-notifications@w3.org>
- Date: Fri, 31 Mar 2017 13:04:39 GMT
- To: public-web-platform-tests-notifications@w3.org
Originally posted as https://github.com/w3c/csswg-test/pull/1057#issuecomment-193509730 by @dholbert on 07 Mar 2016, 23:43 UTC:
> Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.
>
> ---
>
> _[css-flexbox-1/definite-cross-sizes.html, line 1 [r1]](https://reviewable.io:443/reviews/w3c/csswg-test/1057#-KCISF3qOS5PXGXywzXW:-KCISF3qOS5PXGXywzXX:2111335429) ([raw file](https://github.com/w3c/csswg-test/blob/9dbf389412cbc8299de96a1a59ea4723b226226a/css-flexbox-1/definite-cross-sizes.html#L1)):_
> This test's filename ("definite-cross-sizes") probably needs to include e.g. "001", right? Really, it might want to be named percentage-heights-001.html, since it's about percentage heights, and it's using the same `check-layout-th.js` library that the existing percentage-heights-000.html testcase uses.
>
> ---
>
> _[css-flexbox-1/definite-cross-sizes.html, line 5 [r1]](https://reviewable.io:443/reviews/w3c/csswg-test/1057#-KCIS1p6WobdrRZsdFqb:-KCIS1p7rt0_aTK0vJw6:378597318) ([raw file](https://github.com/w3c/csswg-test/blob/9dbf389412cbc8299de96a1a59ea4723b226226a/css-flexbox-1/definite-cross-sizes.html#L5)):_
> For consistency, I think this `<style>` block should come after all of the other boilerplate (the help/author tags in particular).
>
> ---
>
> _Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/w3c/csswg-test/1057)_
>
> <!-- Sent from Reviewable.io -->
View on GitHub: https://github.com/w3c/web-platform-tests/pull/5282#issuecomment-290706356
Received on Friday, 31 March 2017 13:04:54 UTC