Re: [css-flexbox-1-tests] [css-flexbox] Add tests for intrinsic sizing behavior (#5281)

Originally posted as https://github.com/w3c/csswg-test/pull/1022#issuecomment-289594475 by @cbiesinger on 27 Mar 2017, 21:39 UTC:

> 
> 
> 
> 
> Review status: 0 of 4 files reviewed at latest revision, 3 unresolved discussions.
> 
> ---
> 
> *[css-flexbox-1/intrinsic-height-000-ref.html, line 3 at r1](https://reviewable.io:443/reviews/w3c/csswg-test/1022#-KCIApSekZ2bJ7p5pzK4:-KgGhTDFAmZcBGkRa2VZ:b-896fix) ([raw file](https://github.com/w3c/csswg-test/blob/a6416d9d0cbe3b6863e899bcd2e69607dd42b0eb/css-flexbox-1/intrinsic-height-000-ref.html#L3)):*
> <details><summary><i>Previously, dholbert (Daniel Holbert) wrote…</i></summary><blockquote>
> 
> This title is probably too vague; it doesn't really say what the test is testing.
> 
> I think you mean to say, "Test that flex container's intrinsic size is influenced by its items' flex-grow values" or something like that?
> </blockquote></details>
> 
> Done.
> 
> ---
> 
> *[css-flexbox-1/intrinsic-height-000-ref.html, line 30 at r1](https://reviewable.io:443/reviews/w3c/csswg-test/1022#-KCIAjkJTtTxuOhvbLI4:-KgGhTzkjosJSmOkZ-ek:b-896fix) ([raw file](https://github.com/w3c/csswg-test/blob/a6416d9d0cbe3b6863e899bcd2e69607dd42b0eb/css-flexbox-1/intrinsic-height-000-ref.html#L30)):*
> <details><summary><i>Previously, dholbert (Daniel Holbert) wrote…</i></summary><blockquote>
> 
> The phrase "next to" is wrong here, for the height-000 testcase & its reference (which use vertical flex containers whose items are stacked vertically).
> 
> I think you mean to say "above" instead of "next to".
> </blockquote></details>
> 
> Done.
> 
> ---
> 
> *[css-flexbox-1/intrinsic-width-000.html, line 18 at r1](https://reviewable.io:443/reviews/w3c/csswg-test/1022#-KCIC7tIQbW8Wm43USzE:-KgGhUiQ1JY6yVNgLaDG:b-896fix) ([raw file](https://github.com/w3c/csswg-test/blob/a6416d9d0cbe3b6863e899bcd2e69607dd42b0eb/css-flexbox-1/intrinsic-width-000.html#L18)):*
> <details><summary><i>Previously, dholbert (Daniel Holbert) wrote…</i></summary><blockquote>
> 
> It seems here you're assuming that a flex item with "width: 200px; flex: 1 1 0" has a max-content contribution of 200px.  I don't think that's correct. The spec defines flex items' min-content and max-content contributions as being determined by their intrinsic sizes, flex-basis, and min/max-width|height properties, here: https://drafts.csswg.org/css-flexbox-1/#intrinsic-item-contributions .  I don't think that spec-text has any way for "width" or "height" to influence the item's max-content contribution, in your example here (with flex-basis:0)...
> </blockquote></details>
> 
> Done.
> 
> ---
> 
> 
> *Comments from [Reviewable](https://reviewable.io:443/reviews/w3c/csswg-test/1022)*
> <!-- Sent from Reviewable.io -->



View on GitHub: https://github.com/w3c/web-platform-tests/pull/5281#issuecomment-290704288

Received on Friday, 31 March 2017 12:55:32 UTC