- From: Ms2ger <web-platform-tests-notifications@w3.org>
- Date: Mon, 20 Feb 2017 11:43:45 GMT
- To: public-web-platform-tests-notifications@w3.org
Remaining comments: ``` -------------------------------------------------------------------------------- 358| * These selectors are intended to be used with the find() and findAll() methods. Expected results -------------------------------------------------------------------------------- Lachlan Hunt at 2015-01-28 23:27 +00:00: find() and findAll() were the names from the original Selectors API 2 draft. The DOM spec renamed these methods to query() and queryAll(). I also couldn't find any actual test scripts for query() and queryAll(). Those should be written one day. -------------------------------------------------------------------------------- 417| * expect.matches(selector, context) // Only where refNodes is not specified -------------------------------------------------------------------------------- Lachlan Hunt at 2015-01-28 23:07 +00:00: These documentation comments no longer accurately describe how the matches() tests are run because the spec no longer includes support for context/refNodes in matches. Since no matches() tests are run on the selectors below any more, it would be better to move this explanation for the TEST_MATCH type above the other tests that are run for it. General issue: https://critic.hoppipolla.co.uk/showcomment?chain=10265 -------------------------------------------------------------------------------- Lachlan Hunt at 2015-01-28 23:07 +00:00: Element-matches.js still runs tests based on the assumption that matches() takes a second refNodes paramter. You should probably also edit that script to remove that entirely. ``` View on GitHub: https://github.com/w3c/web-platform-tests/pull/1577#issuecomment-281058511
Received on Monday, 20 February 2017 11:43:57 UTC