Re: [custom-elements-tests] third bunch of custom elements tests (#578)

• From: Dominic Cooney <web-platform-tests-notifications@w3.org>
• Date: Wed, 29 Jan 2014 00:44:02 GMT
• To: public-web-platform-tests-notifications@w3.org
• Message-Id: <<web-platform-tests_issue_578_1390956242956@w3.org>>

This indentation doesn't make sense to me, because you've got zero indent at this point, but you indent four characters on the next line. You're mixing indenting aesthetically (make the function look good) and indenting continuations (logical but ugly.)

Maybe you should use more lines, eg:

assert_throws(
    'NotSupportedError',
    function() { doc2.registerElement(name); },
    'Registering a custom element ... ' +
        'registry ...');

View on GitHub: https://github.com/w3c/web-platform-tests/pull/578#discussion_r9252664

Received on Wednesday, 29 January 2014 00:44:09 UTC