- From: Anne van Kesteren <annevk@annevk.nl>
- Date: Thu, 30 Oct 2014 12:28:33 +0100
- To: Ilya Grigorik <igrigorik@google.com>
- Cc: Mark Nottingham <mnot@mnot.net>, William Chan (ιζΊζ) <willchan@chromium.org>, Peter Lepeska <bizzbyster@gmail.com>, Tobin Titus <tobint@microsoft.com>, Patrick McManus <pmcmanus@mozilla.com>, public-web-perf <public-web-perf@w3.org>, Tony Gentilcore <tonyg@chromium.org>
On Thu, Oct 23, 2014 at 6:17 PM, Ilya Grigorik <igrigorik@google.com> wrote: > So, if the response comes from cache, is a local resource, etc, then we skip > over 17 and networkProtocol is null... which, I think, makes sense? Same > logic would apply for Resource Timing as well. You did not mark the attribute nullable. But I wouldn't return null from something that typically returns a string if I could avoid it. Returning the empty string seems better. Also, if there's a fixed list of protocol IDs the browser support, an enum would be more appropriate, updated over time. > http://w3c.github.io/navigation-timing/#processing-model This seems to tack a lot of information on top of https://fetch.spec.whatwg.org/ without actually defining it at the core. It would be better if this information was defined in Fetch and these API drafts just exposed it. See also https://www.w3.org/Bugs/Public/show_bug.cgi?id=23878 for some exploration how to better approach defining the various things resource and navigating timing attempt to define. -- https://annevankesteren.nl/
Received on Thursday, 30 October 2014 11:29:01 UTC