Re: PR: Add support for STYLE blocks (inline style)

Looks good on a quick review.

Do we need to advise people what to do if they want “—>” in their stylesheet?  I suppose the escaping or work-arounds depend on where they need this text, though, right, which makes advice hard?


> On Oct 21, 2015, at 19:18 , Simon Pieters <simonp@opera.com> wrote:
> 
> Hello
> 
> To resolve https://www.w3.org/Bugs/Public/show_bug.cgi?id=15023 I have worked on the following pull-request:
> 
> https://github.com/w3c/webvtt/pull/219
> 
> I would appreciate a review of the changes.
> 
> If you prefer viewing an HTML diff, please see:
> 
> http://services.w3.org/htmldiff?doc1=https%3A%2F%2Fraw.githubusercontent.com%2Fw3c%2Fwebvtt%2Fgh-pages%2Findex.html&doc2=https%3A%2F%2Fraw.githubusercontent.com%2Fw3c%2Fwebvtt%2F7a83b0183ce44d2be62433e81f1b06d49bda22e9%2Findex.html
> 
> (Note that the HTML diff might be out of date if I add more commits to the PR.)
> 
> cheers
> -- 
> Simon Pieters
> Opera Software
> 

David Singer
Manager, Software Standards, Apple Inc.

Received on Friday, 23 October 2015 08:27:36 UTC