W3C home > Mailing lists > Public > public-svg-wg@w3.org > April to June 2008

Tiny 1.2 testsuite release review

From: Erik Dahlström <ed@opera.com>
Date: Thu, 05 Jun 2008 12:58:00 +0200
To: "public-svg-wg@w3.org" <public-svg-wg@w3.org>
Message-ID: <op.ub9veyp9gqiacl@gnorps>

Hello svg-wg,

Just took a quick run through the generated 1.2T testsuite:

  http://www.w3.org/Graphics/SVG/Group/repository/testsuite/1.2T/archives/W3C_SVG_12_TinyTestSuite.tar.gz

General comments
----------------
The visual consistency of the testsuite is poor, which is to be expected since tests have been gathered for a long time, and created by many companies etc. I think this is something we should try to improve over time. For example by conventions such as "pass conditions should be marked in green/lime", "fail conditions should be marked in red", "pass conditions that may need manual inspection should be marked in blue". We should consistently use the strings "Failed" and "Passed" if marking the success of tests, perhaps there should even be a specific placement of such a message. There could be a particular shape used for a pass, and one for fail.

Overall the testsuite quality is such that I would personally rate it alpha (considering the many errors in reference images). The quality of individual testcases is varied but on the whole quite good.

Comments on the testsuite
-------------------------

- Wrong revision numbers in reference image:
  animate-elem-02-t - animate-elem-15-t
  animate-elem-19-t - animate-elem-34-t
  animate-elem-36-t - animate-elem-37-t
  animate-elem-39-t - animate-elem-41-t
  animate-elem-44-t
  animate-elem-46-t
  animate-elem-52-t
  animate-elem-53-t
  animate-elem-60-t - animate-elem-70-t
  animate-elem-77-t
  animate-elem-78-t
  animate-elem-80-t - animate-elem-86-t
  animate-elem-202-t
  animate-elem-207-t
  animate-elem-219-t
  animate-elem-221-t
  animate-elem-225-t
  animate-elem-227-t
  coords-constr-204-t
  coords-trans-01-t - coords-trans-09-t
  coords-units-01-t
  coords-viewattr-05-t
  extend-namespace-02-t
  fonts-desc-03-t
  fonts-desc-05-t
  fonts-elem-01-t - fonts-elem-03-t
  fonts-kern-01-t
  interact-dom-02-t
  interact-event-201-t
  interact-focus-201-t
  interact-focus-202-t
  interact-focus-204-t
  interact-focus-205-t
  interact-focus-211-t
  interact-order-04-t
  interact-order-05-t
  interact-order-06-t
  interact-pevents-01-t - interact-pevents-04-t
  interact-pevents-08-t
  interact-zoom-01-t
  interact-zoom-02-t
  interact-zoom-03-t
  intro-compat-201-t
  jpeg-required-201-t
  linking-a-09-t
  linking-frag-203-t
  linking-refs-203-t
  linking-refs-206-t
  linking-uri-01-t
  linking-uri-02-t
  media-alevel-201-t - media-alevel-203-t
  media-alevel-206-t
  media-anim-201-t
  media-anim-204-t - media-anim-210-t
  media-audio-214-t
  media-audio-215-t
  media-video-202-t - media-video-203-t
  media-video-205-t - media-video-213-t
  media-video-218-t
  media-video-220-t
  media-video-222-t
  metadata-example-01-t
  paint-color-01-t
  paint-color-03-t - paint-color-05-t
  paint-grad-04-t
  paint-grad-05-t
  paint-grad-07-t - paint-grad-09-t
  paint-grad-11-t
  paint-grad-12-t
  paint-grad-15-t - paint-grad-19-t
  paint-grad-202-t
  paint-grad-204-t
  paint-vfill-206-t
  paths-data-01-t
  paths-data-02-t
  paths-data-04-t - paths-data-10-t
  paths-data-12-t - paths-data-15-t
  render-elems-01-t - render-elems-03-t
  render-elems-06-t - render-elems-08-t
  render-groups-01-t
  render-groups-03-t
  script-element-203-t
  script-handle-05-t - script-handle-08-t
  shapes-circle-01-t - shapes-circle-03-t
  shapes-ellipse-01-t - shapes-ellipse-03-t
  shapes-intro-01-t
  shapes-line-01-t
  shapes-polygon-01-t
  shapes-polyline-01-t
  shapes-rect-01-t
  shapes-rect-02-t
  struct-common-201-t
  struct-cond-01-t - struct-cond-03-t
  struct-cond-205-t - struct-cond-207-t
  struct-defs-01-t
  struct-defs-201-t
  struct-discard-201-t
  struct-discard-202-t
  struct-discard-205-t - struct-discard-207-t
  struct-frag-05-t
  struct-group-01-t
  struct-image-01-t
  struct-image-03-t
  struct-image-04-t
  struct-progressive-201-t
  struct-svg-201-t - struct-svg-203-t
  struct-use-04-t
  struct-use-202-t
  struct-use-205-t
  styling-inherit-01-t - styling-inherit-03-t
  styling-pres-01-t
  text-align-01-t
  text-align-07-t
  text-align-202-t
  text-area-201-t
  text-area-203-t - text-area-207-t
  text-area-209-t - text-area-210-t
  text-area-212-t
  text-area-213-t
  text-area-220-t - text-area-222-t
  text-area-224-t
  text-edit-201-t
  text-fonts-01-t
  text-fonts-02-t
  text-fonts-203-t
  text-intro-01-t
  text-intro-04-t
  text-intro-06-t
  text-text-05-t
  text-text-06-t
  text-text-08-t
  text-text-09-t
  text-tselect-03-t
  text-ws-01-t
  text-ws-02-t
  udom-dom-204-t
  udom-dom-209-t
  udom-dom-210-t
  udom-dom-212-t
  udom-dom-213-t
  udom-event-203-t
  udom-event-205-t
  udom-event-206-t
  udom-event-207-t
  udom-event-208-t
  udom-event-209-t
  udom-event-210-t
  udom-glob-203-t
  udom-glob-204-t
  udom-node-201-t
  udom-over-01-t
  udom-svg-206-t
  udom-svg-208-t - udom-svg-210-t
  udom-svg-212-t - udom-svg-216-t
  udom-svg-218-t
  udom-svg-220-t - udom-svg-228-t
  udom-svg-231-t - udom-svg-233-t
  udom-svg-236-t - udom-svg-237-t
  udom-svgcolor-201-t
  udom-svglocatable-201-t - udom-svglocatable-203-t
  udom-svgmatrix-201-t - udom-svgmatrix-207-t
  udom-svgpath-201-t - udom-svgpath-202-t
  udom-svgpoint-201-t - udom-svgpoint-202-t
  udom-svgrect-201-t
  udom-textcontent-201-t - udom-textcontent-202-t
  udom-traitaccess-203-t - udom-traitaccess-206-t

- Test still has draft mark, but is included in the release (some of these look very unfinished, some are quite far along, should some be removed from the release?)
  animate-elem-61-t
  animate-elem-62-t
  animate-elem-63-t
  animate-elem-86-t
  animate-elem-204-t
  animate-elem-221-t
  animate-elem-224-t
  animate-elem-225-t
  fonts-elem-201-t
  fonts-glyph-202-t
  interact-focus-208-t
  interact-focus-209-t
  interact-pevents-01-t
  interact-pevents-03-t
  interact-pevents-04-t
  linking-a-09-t
  linking-a-201-t
  linking-uri-01-t
  linking-uri-02-t
  media-audio-214-t
  paint-stroke-206-t
  paths-data-14-t
  struct-common-201-t
  struct-cond-03-t
  struct-cond-206-t
  struct-cond-207-t
  struct-discard-203-t
  struct-use-06-t
  struct-use-07-t
  text-align-203-t
  text-area-202-t
  text-area-208-t
  text-area-211-t
  text-area-223-t
  text-area-224-t
  text-area-225-t
  text-fonts-203-t
  text-intro-06-t
  text-text-05-t
  types-data-201-t
  types-data-202-t
  udom-conform-201-t
  udom-dom-204-t
  udom-dom-209-t
  udom-dom-212-t
  udom-event-205-t
  udom-event-206-t
  udom-event-208-t
  udom-event-210-t
  udom-svg-203-t
  udom-svg-206-t
  udom-svg-207-t
  udom-svg-212-t
  udom-svg-213-t
  udom-svg-214-t
  udom-svg-215-t
  udom-svg-217-t
  udom-svg-219-t - udom-svg-223-t
  udom-svg-229-t
  udom-svgmatrix-205-t - udom-svgmatrix-207-t
  udom-svgpoint-202-t
  udom-svgtimedelement-202-t - udom-svgtimedelement-205-t
  udom-traitaccess-201-t - udom-traitaccess-202-t

- Error in the reference image itself:
  coords-pAR-201-t (missing the aligned images)
  media-video-219-t (minor overlap of the text 6(s))
  paint-stroke-07-t (only the topmost shape should have an uncut linejoin)
  paint-stroke-206-t (reference image looks weird)
  struct-common-201-t (shows red circles instead of green)
  struct-use-06-t (missing reference image)
  struct-use-07-t (missing reference image)
  struct-use-201-t (the image in the B rect should not overflow)
  styling-inherit-03-t (should show four green rects)
  text-area-201-t, text-area-203-t - text-area-207-t, text-area-210-t (Revision text looks bigger than it should in the reference image)
  text-area-207-t (svg has draft mark, but reference does not)
  text-area-224-t (missing text in textAreas)
  types-data-201-t - types-data-202-t (doesn't match the description)
  udom-conform-201-t (should have blue rect and 4 x the string "pass")
  udom-dom-204-t (should have six blue rects)
  udom-dom-205-t, udom-dom-208-t (multiple errors, svggen has draft mark reference does not)
  udom-dom-212-t (should show 10 blue rects)
  udom-event-209-t (should show blue rect)
  udom-smil-203-t (doesn't show the end state)
  udom-svg-206-t (should show blue rects)
  udom-svg-212-t (should show green rect)
  udom-svg-213-t (should show blue rects)
  udom-svg-214-t (should show green rect)
  udom-svg-219-t - udom-svg-223-t (mismatch with description)
  udom-svg-229-t (shows failed state)
  udom-svg-230-t (should be in draft)
  udom-svgpath-202-t (bad rendering, wrong size?)
  udom-svgpoint-202-t (says failed, test header looks incorrect)
  udom-svgrect-201-t (says failed)
  udom-traitaccess-201-t - udom-traitaccess-202-t (says error)
  udom-traitaccess-205-t (should be in draft)

- Error in harness:
  - htmlObjectHarness/struct-common-201-t-debug.html should be removed

- Doesn't use the SVGFreeSans font for the $Revision text:
  media-anim-201-t - media-anim-210-t
  media-video-201-t - media-video-214-t
  struct-cond-204-t
  text-area-211-t - text-area-212-t
  text-area-213-t
  text-area-220-t - text-area-222-t
  udom-svg-231-t - udom-svg-232-t, udom-svg-236-t (wrong font for passed/fail field)

- Overlapping text and graphics
  media-audio-204-t
  media-audio-208-t
  media-audio-210-t
  media-video-217-t
  media-video-218-t
  media-video-221-t
  udom-svg-207-t
  udom-svg-210-t
  udom-svg-211-t
  udom-svgtimedelement-203-t - udom-svgtimedelement-205-t

- Invalid tests, should be marked as draft and have reference images regenerated:
  udom-svg-234-t
  udom-svg-235-t
  udom-svglocatable-204-t (Test assumes that the viewport is 400x400pixels, but that is not the case in FF3 and Opera 9.5. An svg that has a viewBox and where the size is determined by the embedding element will override the width and height on the referenced svg (the svg will scale to fit the entire viewport).)

- udom-traitaccess-203-t: should use epsilon comparisons

Cheers
/Erik

-- 
Erik Dahlstrom, Core Technology Developer, Opera Software
Co-Chair, W3C SVG Working Group
Personal blog: http://my.opera.com/macdev_ed
Received on Thursday, 5 June 2008 10:58:42 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 5 June 2008 10:58:43 GMT