Re: Promises - review of use in Network Service Discovery draft?

On Wed, Jul 24, 2013 at 10:02 AM,  <Frederick.Hirsch@nokia.com> wrote:
> Dear list members (cc'd DAP):
>
> The Device API working group (DAP) is working on a specification 'Network Service Discovery'.
>
> "This specification defines a mechanism for an HTML document to discover and subsequently communicate with HTTP-based services advertised via common discovery protocols within the current network."
>
> <https://dvcs.w3.org/hg/dap/raw-file/tip/discovery-api/Overview.html>
>
> Rich Tibbett, the editor, has updated the editors draft to use 'Promises' as noted in his message below.
>
> Would members of the list that have experience with Promises please (if possible) review the Promises usage in this editors draft and let the DAP WG know of any concerns or best practices that we need to consider (or confirm that our usage looks good)?

This is a rather late response, but the use of Promises appears fine
at first blush.

Use of integer constants is bad.  Make an enum with the values
instead, and have the error contain an attribute of that enum type.

I had a comment about not putting everything on navigator, but this
might actually be validly connected to the navigator.

~TJ

Received on Wednesday, 28 August 2013 18:13:24 UTC