RE: Test suite specs

Hi Leroy, all,

 

I would tend to disagree :)

 

Those files are test results that are going to be (and are already in our case) used in unit tests in the builds of some production-grade applications. They simply must be predictable and consistent. Not all comparison tool can deal with different ordering of the lines for example, or present/absent white spaces.

 

The only way to have a predictable line order is to sort the attributes alphabetically. So I think we should do that.

 

For the trailing whitespace, it’s doesn’t matter if they are there or not, but they need to be either always there or never.

 

We could update the files to reflect that, but it is more efficient in the long run to make sure the process you are using to generate them does it by itself.

 

Cheers,

-yves

 

 

From: Leroy Finn [mailto:finnle@tcd.ie] 
Sent: Wednesday, October 24, 2012 3:08 AM
To: Fredrik Liden
Cc: Multilingual Web LT-TESTS Public
Subject: Re: Test suite specs

 

The alphabetical order is not a major problem for my comparison engine once the output lines in the actual files are correct.  You can include them if you want its no big deal if you don't want the trailing tab and empty line at the end. The main thing is that the output lines are correct and the ordering is not that important.

 

Thanks,

Leroy

On 23 October 2012 21:36, Fredrik Liden <fliden@enlaso.com> wrote:

Hi Leroy,          

 

Thanks for adding me.

 

In example 6 and 7 there is an instance of 

 

<item type="title" its:translate="yes">

 

The test suite result is:

/doc/info[1]/item[1]     its:translate="yes"

/doc/info[1]/item[1]/@type     its:translate="no"

/doc/info[1]/item[1]/@its:translate      its:translate="no"

 

Is this correct or should  the attributes in alphabetical order? I think there might be instances in some other categories as well.

/doc/info[1]/item[1]     its:translate="yes"

/doc/info[1]/item[1]/@its:translate      its:translate="no"

/doc/info[1]/item[1]/@type     its:translate="no"

 

An email from 8/31 that mentions alphabetical order since the xml parsers do not guarantee attribute order.

 

Btw, I noticed each line in the test files ends with  \t\r\n. (Tab and Linebreak),  I wonder if the trailing \t should be there. There’s also a trailing empty row at the end of each result file, should we include that?

 

Just in case we need to update our current test result engine so the file comparison test passes.

 

Cheers,

Fredrik