Re: Allowed characters - added HTML global rules embedded case

Hi Leroy,

thanks a lot. A small suggestion: would it make sense to replace

//h:*[@id=$translateparam]/@id

with

//h:*[@id=$translateparam]

so that the "code" element matches and not its "id" attribute? It looks 
like a better fit in the example.

Best,

Felix

Am 19.12.12 17:09, schrieb Leroy Finn:
> Sorry for the delay I had to fix one or two other issues in the 
> parser. I have posted the first example to the git hub for translate 
> and I will hopefully publish all of them tomorrow:
>
> Input: 
> https://github.com/finnle/ITS-2.0-Testsuite/blob/master/its2.0/inputdata/translate/html/translate7html.html
> Output: 
> https://github.com/finnle/ITS-2.0-Testsuite/blob/master/its2.0/expected/translate/html/translate7htmloutput.txt
>
> Leroy
>
>
> On 19 December 2012 13:47, Leroy Finn <finnle@tcd.ie 
> <mailto:finnle@tcd.ie>> wrote:
>
>     Ok so the new HTML test will use its:param and be embedded as per
>     spec. I will get working on this today.
>
>     Leroy
>
>
>     On 19 December 2012 12:16, Felix Sasaki <fsasaki@w3.org
>     <mailto:fsasaki@w3.org>> wrote:
>
>         Am 19.12.12 13:11, schrieb Leroy Finn:
>>         Thanks Felix for the clarification I will look into getting
>>         the tests added in today.
>
>         Great, thanks, Leroy. Btw., Yves is right about its:param in
>         the separate mail in this thread. It is a mandatory feature
>         anyway, so you can create just one embeded test file with
>         its:param to kill two birds with one stone.
>
>         Best,
>
>         Felix
>
>
>>
>>         Leroy
>>
>>
>>         On 19 December 2012 12:09, Felix Sasaki <fsasaki@w3.org
>>         <mailto:fsasaki@w3.org>> wrote:
>>
>>             Hi Leroy,
>>
>>             good question. I don't think we need an extra test case
>>             for global rules with its:param in HTML. However having
>>             global rules embedded in HTML in general would be good.
>>             This demonstrates that the implementation can parse the
>>             HTML "script" element during the "gathering rules" step.
>>
>>             For each data category you have various linked rules
>>             tests , e.g. " Global - Linked rules with
>>             locNotePointer", " Linked rules with locNoteRef", ...
>>             It would be sufficient to have just one test per data
>>             category with rules embedded in HTML. It would be totally
>>             ok if the tests are identical to the linked version, with
>>             the only difference being the inline usage. So for
>>             creating the test case, practically you could just copy a
>>             file like
>>             locnote1html.html
>>             add "script" with the rules embedded, and be done with it.
>>
>>             Best,
>>
>>             FElix
>>
>>             Am 19.12.12 12:49, schrieb Leroy Finn:
>>>             Hey Yves, Everybody,
>>>
>>>             Thanks for this. A quick question though do I have to
>>>             have an example for each data category for the HTML
>>>             global embedded case because as far as I was aware it
>>>             only applied to Provenance and LQI. Also if each data
>>>             category requires this test then we will also need to
>>>             test for the HTML global rules embedded case with
>>>             its:param????
>>>
>>>             Thanks,
>>>             Leroy
>>>
>>>
>>>             On 18 December 2012 13:00, Yves Savourel
>>>             <ysavourel@enlaso.com <mailto:ysavourel@enlaso.com>> wrote:
>>>
>>>                 Hi Leroy, all,
>>>
>>>                 I've added the missing test case for HTML global
>>>                 rules embedded for HTML to the Allowed Characters
>>>                 data category.
>>>                 See
>>>                 https://github.com/finnle/ITS-2.0-Testsuite/commit/128d5186c797642f2ee0342fdbc8589cc539aec4
>>>
>>>                 cheers,
>>>                 -yves
>>>
>>>
>>>
>>>
>>>
>>
>>
>
>
>