W3C home > Mailing lists > Public > public-mobileok-checker@w3.org > March 2008

Re: [Bug 5537] Checker aborts on bad URI in redirect

From: Sean Owen <srowen@google.com>
Date: Thu, 6 Mar 2008 21:35:03 -0500
Message-ID: <e920a71c0803061835u37db642dp6ae84eaf253c70ca@mail.gmail.com>
To: public-mobileok-checker <public-mobileok-checker@w3.org>

Question on this one -- according to the code this is kinda intended
behavior. If the last request ended in some kind of exception we
assume we don't actually have a document to test, so there are no
results to report.

I kind of agree with this and recall a long argument on a whiteboard
about this. Just checking, what do people think about the right
behavior here? Garbage in, garbage out, I say, so I am not
particularly concerned if a situation like this results in an
exception (subsequently, looks like a change has turned this internal
exception into a more appropriate TestException), or if it becomes
some meaningless test results stating that the result is fail fail
fail because the body is empty and all kinds of screwed up as a
result. Just a different garbage out.

I'm happy to 'fix' this, just want to know if everyone agrees with
that, or whether this needs discussion.

Sean

On Thu, Mar 6, 2008 at 11:40 AM,  <bugzilla@farnsworth.w3.org> wrote:
> http://www.w3.org/Bugs/Public/show_bug.cgi?id=5537
>
>            Summary: Checker aborts on bad URI in redirect
>            Product: mobileOK Basic checker
>            Version: unspecified
>           Platform: PC
>         OS/Version: Linux
>             Status: NEW
>           Severity: normal
>           Priority: P2
>          Component: Java Library
>         AssignedTo: srowen@google.com
>         ReportedBy: dom@w3.org
>
>
>  similar to #5536, when we try to resolve a URI for a redirect, the checker
>  aborts with the following trace when the URI is invalid:
>  xception in thread "main" java.lang.IllegalArgumentException: Invalid uri
>  'http://himedia.112.2o7.net/b/ss/hmReportSuiteID/1/H.10--NS/0?[AQB]&pccr=true&g=none&[AQE]':
>  Invalid query
>         at
>  org.apache.commons.httpclient.HttpMethodBase.<init>(HttpMethodBase.java:222)
>         at
>  org.apache.commons.httpclient.methods.GetMethod.<init>(GetMethod.java:89)
>         at
>  org.w3c.mwi.mobileok.basic.HTTPResource.<init>(HTTPResource.java:110)
>         at org.w3c.mwi.mobileok.basic.HTTPResource.<init>(HTTPResource.java:82)
>         at
>  org.w3c.mwi.mobileok.basic.HTTPImageResource.<init>(HTTPImageResource.java:38)
>         at
>  org.w3c.mwi.mobileok.basic.Preprocessor.preprocess(Preprocessor.java:111)
>         at
>  org.w3c.mwi.mobileok.basic.Tester.getPreprocessorResults(Tester.java:79)
>         at org.w3c.mwi.mobileok.basic.Tester.main(Tester.java:191)
>
>  This would again be better reported as HTTP_RESPONSE-1
>
Received on Friday, 7 March 2008 02:35:20 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 7 March 2008 02:35:21 GMT