W3C home > Mailing lists > Public > public-media-fragment@w3.org > July 2011

Test case review TC0027 - TC0065

From: Silvia Pfeiffer <silviapfeiffer1@gmail.com>
Date: Wed, 6 Jul 2011 22:34:58 +1000
Message-ID: <CAHp8n2kUcS-0iocxR4a8pGFQWMpLZnX8a34YY8XgbWhsZt6w1g@mail.gmail.com>
To: Media Fragment <public-media-fragment@w3.org>
Hi all,

I've done my action from today's meeting and reviewed test cases 0027
to 0065. The results are all ok, but I have some suggestions on
changes to some comments.

Cheers,
Silvia.


TC0027 to TC0033 and TC0044 all fall into the class of non-parsing
temporal fragments. Thus the UA throws it away and downloads the full
resource.
I agree.


TC0034 uses an escaped equals sign (%3D). This percent-encoding does
not resolve since the equals sign is a separator, thus the fragment
string is not interpreted as a media fragment. I think the effect of
the test is correct, but the explanation why it fails in the comment
is incorrect.
I suggest replacing
"UA knows that this is an invalid media fragment" -> "UA does not
identify this as a media fragment"...


TC0035 to TC0039 all use escaped characters in a temporal fragment,
but not for the equals sign. Thus a media fragment is requested.
I agree.


TC0045 to TC0047 all represent valid spatial fragments. TC0047 states
a conversion from percent to pixels, but I was not able to find a
statement of the resolution of the full video.
I suggest adding "The video's full resolution is 1280x720px".


TC0048 uses a width and height of 0 for the cropped area. I don't
think that's invalid according to our production rules. Even though
our informative section 6.1.2 states that the width and height need to
be larger than 0 to be valid, that's not what the production rules
state.
I suggest replacing
"Invalid spatial coordinates." -> "Invalid semantics: width and height
of cropped region must be larger than 0. The media fragment is
ignored."


Similarly TC0050 uses a width and height of more than 100% for the
cropped area. I don't think that's invalid according to our production
rules. Even though our informative section 6.1.2 states that a+c <=
100 and b+d <= 100 to be valid, that's not what the production rules
state.
I suggest replacing
"Invalid spatial coordinates." -> "Invalid semantics: width and height
of cropped region must be larger than 0. The media fragment is
ignored."


TC0049 is an invalid spatial fragment. Thus the UA throws it away.
I agree.


TC0051 to TC0054 all test multiple name-value pairs in a URL. All bar
one temporal fragment survives after throwing out all the invalid
ones.
I agree.


TC0055 to TC0056, TC0059 to TC0060 are according to spec.
I agree.


TC0057 should state that the full media resource is downloaded.


TC0058 is not a media fragment.
I suggest replacing
"UA knows that this is an invalid media fragment" -> "UA does not
identify this as a media fragment"...


TC0061 to TC0065 all fall into the class of non-parsing temporal
fragments. Thus the UA throws it away and downloads the full resource.
I agree. Even though at one stage we decided to make TC0064 valid as
an exception. ;-)
Received on Wednesday, 6 July 2011 12:35:45 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Wednesday, 21 September 2011 12:13:43 GMT