Re: IDL/API feedback

On 2013-04-08 10:15, Anne van Kesteren wrote:
> On Mon, Apr 8, 2013 at 9:02 AM, Adam Bergkvist
> <adam.bergkvist@ericsson.com> wrote:
>> Which methods are you referring to? It's deliberate that addTrack() and
>> removeTrack() don't fire this event. The event is intended to notify the
>> script that, for example, the remote and has added a track to a stream that
>> you're receiving. Therefore, nothing in the Media Capture spec fires this
>> event a.t.m..
>
> It might be worth clarifying that.

I did add some text to the "addtrack" and "removetrack" tables in the 
"Event summary" section about this, as a result of some previous 
feedback [1]. Will that do it?

>>> You need a copy. If you'd actually pass by value the developer could
>>> make further changes later that would have to be reflected by the
>>> object, which is not what you want at all.
>>
>> I suspect you mean pass by reference above. It not really a problem in our
>> case since the MediaStream constructor only reads the content of the list;
>> it doesn't adopt it. Thus, the copy is in vain.
>
> I just read the relevant sections of IDL again. If you convert an ES
> value to an IDL array it'll go through the convert to sequence steps
> anyway. Unless it's the rare case of it being a platform array object,
> which it almost certainly is not.

True. In that case it might be motivated to change to a sequence since 
that describes what actually happens more directly (i.e. without the T[] 
detour).

[1] https://bugs.webkit.org/show_bug.cgi?id=111079

Received on Monday, 8 April 2013 09:00:10 UTC