- From: Markus Lanthaler via GitHub <sysbot+gh@w3.org>
- Date: Tue, 05 Sep 2017 18:57:25 +0000
- To: public-hydra-logs@w3.org
Looks great. Thanks Pavlik. Unless anyone objects, I'd like to merge this as soon as Pavlik fixed the minor coding style issues.
---
Review status: 0 of 2 files reviewed at latest revision, 2 unresolved discussions.
---
*[drafts/use-cases/1.1.security-considerations.md, line 29 at r1](https://reviewable.io:443/reviews/hydracg/specifications/136#-KtINlaUib39XDrD57NA:-KtINlaUib39XDrD57NB:bmqkox9) ([raw file](https://github.com/hydracg/specifications/blob/5f120fda0851d14713a6071bc7ce0d530d0df3f0/drafts/use-cases/1.1.security-considerations.md#L29)):*
> ```Markdown
> "operation": [
> {
> "@type": ["hydra:Operation", "schema:CreateAction"],
> ```
Could you please fix the indentation of `@type` here. And while you are at it, could you please also simplify this and the blocks below by not wrapping a single operation into an array.
---
*[drafts/use-cases/1.entry-point.md, line 38 at r1](https://reviewable.io:443/reviews/hydracg/specifications/136#-KtIO9-2TaYIbrrc-vGJ:-KtIO7rq00vQdQnAxovA:bzibiky) ([raw file](https://github.com/hydracg/specifications/blob/5f120fda0851d14713a6071bc7ce0d530d0df3f0/drafts/use-cases/1.entry-point.md#L38)):*
> ```Markdown
> "@type": "hydra:EntryPoint",
> "collection": [
> {
> ```
Please make the indentation consistent. We have a mixture of 2 and 4 spaces in this file. I like 2 :-)
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/136#-:-KtIOdvh-MffsfbjR5jC:bpx0hm5)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by lanthaler
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/136#issuecomment-327270419 using your GitHub account
Received on Tuesday, 5 September 2017 18:57:24 UTC