- From: Markus Lanthaler via GitHub <sysbot+gh@w3.org>
- Date: Mon, 13 Nov 2017 00:46:36 +0000
- To: public-hydra-logs@w3.org
<img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src="https://reviewable.io/lgtm.png" height="20" width="61"/> apart from the invalid Turtle. Thanks Tomasz
---
Reviewed 9 of 9 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.
---
*[drafts/use-cases/1.entry-point.md, line 108 at r1](https://reviewable.io:443/reviews/hydracg/specifications/151#-KymoDAKf8p01szEP32h:-KymoDAKf8p01szEP32i:bxm21yn) ([raw file](https://github.com/hydracg/specifications/blob/be8fbecf591bcf785f9d14015e140e18c4efe32e/drafts/use-cases/1.entry-point.md#L108)):*
> ```Markdown
>
> ```ttl
> [] a Operation .
> ```
This is invalid Turtle. [Prefixed names always need to contain a colon](https://www.w3.org/TR/turtle/#grammar-production-iri). I would suggest to keep using `hydra:` in Turtle.
---
*[drafts/use-cases/5.1.creating-event-with-put.md, line 32 at r1](https://reviewable.io:443/reviews/hydracg/specifications/151#-KymopwjgcEw_ZW_fpBz:-KymopwjgcEw_ZW_fpC-:b-ghi1rz) ([raw file](https://github.com/hydracg/specifications/blob/be8fbecf591bcf785f9d14015e140e18c4efe32e/drafts/use-cases/5.1.creating-event-with-put.md#L32)):*
> ```Markdown
>
> var client = new HydraClient();
> var memberTemplate = client.get('http://example.com/events')['memberTemplate'];
> ```
@alien-mcl , should we use something like `hydra.memberTemplate` here instead? Then we would get auto-completion etc. as well.
---
*[drafts/use-cases/6.updating-event.md, line 40 at r1](https://reviewable.io:443/reviews/hydracg/specifications/151#-Kymp8CFXH-WlyuTR4QA:-Kymp8CGSBpV1sZB1yUc:b-s1b3le) ([raw file](https://github.com/hydracg/specifications/blob/be8fbecf591bcf785f9d14015e140e18c4efe32e/drafts/use-cases/6.updating-event.md#L40)):*
> ```Markdown
> "@context": "/api/context.jsonld",
> "@id": "/api/events/1",
> "@type": ["schema:Event", "Resource"],
> ```
Let's simplify this and remove `Resource` altogether while we are at it.
---
*Comments from [Reviewable](https://reviewable.io:443/reviews/hydracg/specifications/151#-:-Kympde2f3iSYBKnwCbm:b-pe82lw)*
<!-- Sent from Reviewable.io -->
--
GitHub Notification of comment by lanthaler
Please view or discuss this issue at https://github.com/HydraCG/Specifications/pull/151#issuecomment-343782830 using your GitHub account
Received on Monday, 13 November 2017 00:46:41 UTC