W3C home > Mailing lists > Public > public-html-testsuite@w3.org > August 2012

Re: Submit two test cases for contentEditable and designMode attributes

From: Aryeh Gregor <ayg@aryeh.name>
Date: Thu, 16 Aug 2012 16:53:11 +0300
Message-ID: <CAKA+AxmP=xNCWEjS3MgDDkjnqiFcfr7r4TQe8Q7KikoyPk-2+g@mail.gmail.com>
To: guopengcheng <guopengcheng@baidu.com>
Cc: public-html-testsuite@w3.org
On Thu, Aug 16, 2012 at 12:23 PM, guopengcheng <guopengcheng@baidu.com> wrote:
> We’d like to submit two new test cases for HTML5 attributes contentEditable
> and designMode. Could someone help to review them? Many thanks.
>
>
>
> Following is the general info:
>
>
>
> [Case Name]:  contentEditable attribute test
>
> [Case Path]:
> http://w3c-test.org/html/tests/submission/Baidu/editing/user-interaction-editing-contenteditable.html
>
> [Description]:  This test focused on attribute contentEditable, whose rules
> is defined in http://www.w3.org/TR/html5/editing.html#contenteditable
>
>                             Test case covers different input values of this
> attribute, as well as the child elements with this attribute.
>
>
>
> [Case Name]:  designMode attribute test
>
> [Case Path]:
> http://w3c-test.org/html/tests/submission/Baidu/editing/user-interaction-editing-designMode.html
>
> [Description]:  This test focused on attribute designMode, whose rules is
> defined in
> http://www.w3.org/TR/html5/editing..html#making-entire-documents-editable:-the-designmode-idl-attribute
>
>                             Test case covers different input values of this
> attribute.

Thanks for the tests!  Here's some feedback:

1) Please name your tests.  E.g., instead of

   test(function() {
    assert_equals(testElement.contentEditable,"inherit", "check for
testElement.contentEditable value");
   });

do

   test(function() {
    assert_equals(testElement.contentEditable,"inherit", "check for
testElement.contentEditable value");
   }, "no contenteditable attribute");

and maybe call the next one 'contenteditable=""', etc.  Otherwise
their names default to "Editing: contentEditable attribute test",
"Editing: contentEditable attribute test 1", and so on, so it's not
clear what the browser is failing.

2) You name all your asserts "check for testElement.contentEditable
value".  You should call the ones that check isContentEditable "check
for testElement.isContentEditable value" instead.  (This is just a
typo.)


I've reviewed both of your tests, and if you fix those two problems I
support their approval.  Per the current policy
<http://www.w3.org/html/wg/wiki/Testing/Approval/>, it looks like if
no one else has objections, they'll be approved after two conference
call meetings, i.e., about four weeks.

Thanks again for your contribution!
Received on Thursday, 16 August 2012 13:54:01 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Thursday, 16 August 2012 13:54:01 GMT