W3C home > Mailing lists > Public > public-html-testsuite@w3.org > February 2011

Re: Simple sematic tests

From: James Graham <jgraham@opera.com>
Date: Tue, 08 Feb 2011 11:22:56 +0100
Message-ID: <4D511980.20206@opera.com>
To: Kris Krueger <krisk@microsoft.com>
CC: "'public-html-testsuite@w3.org' (public-html-testsuite@w3.org)" <public-html-testsuite@w3.org>
On 02/08/2011 06:09 AM, Kris Krueger wrote:
> I submitted a few sematic tag test cases  - I have found that if a UA implements these tags the pass.
> For example IE9, chrome 9 and Firefox 4...
> If you don't think these tests are normative please speak up.

Well they are clearly normative since they test the DOM interface 

> http://test.w3.org/html/tests/submission/Microsoft/semantic/

I skimmed these and in general I think they are not wrong but not good 
style either. Using assert_array_equals to compare strings in javascript 
is bizarre; assert_equals works fine for this case. Also, testing the 
stringification alone seems wrong, there should probably also be an 
instanceof check (in an ideal world we could walk the prototype chain 
explicitly but since support for ES5's getPrototypeOf is not yet 
widespread, that isn't possible in a standard way).

In any case maybe assert_implements that does both a instanceof check 
and a stringification check should be added to the harness?
Received on Tuesday, 8 February 2011 10:23:38 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 20:14:29 UTC