W3C home > Mailing lists > Public > public-html-testsuite@w3.org > August 2011

Re: Submission of tests

From: Simon Pieters <simonp@opera.com>
Date: Fri, 19 Aug 2011 10:24:08 +0200
To: "public-html-testsuite@w3.org" <public-html-testsuite@w3.org>, Ms2ger <ms2ger@gmail.com>
Message-ID: <op.v0gcaifnidj3kv@simon-pieterss-macbook.local>
On Fri, 19 Aug 2011 10:18:58 +0200, Simon Pieters <simonp@opera.com> wrote:

> On Thu, 18 Aug 2011 21:13:25 +0200, Ms2ger <ms2ger@gmail.com> wrote:
>
>> Hi all,
>>
>> I finished converting my tests [1] to use testharness.js, and would  
>> like to see them reviewed and approved.
>
> I've reviewed the following folders:
>
> drwxr-xr-x			apis-in-html-documents 	files
> drwxr-xr-x			browsing-the-web 	files
> drwxr-xr-x			dom-tree-accessors 	files
> drwxr-xr-x			dynamic-markup-insertion 	files
>
>
> Comments:
>
> # [10:00] <zcorpan> Ms2ger:  
> http://dvcs.w3.org/hg/html/file/f8b7e4633037/tests/submission/Ms2ger/dom-tree-accessors/document.title-07.html  
> doesn't check "expected title"
> # [10:01] <Ms2ger> It's tested in  
> http://dvcs.w3.org/hg/webapps/file/bc93d42ccbe7/DOMCore/tests/submissions/Ms2ger/DOMImplementation-createHTMLDocument.html
> # [10:02] <zcorpan> ah
> # [10:03] <Ms2ger> (I moved the entire test to DOM Core, and then David  
> Flanagan complained that I was testing HTML)
> # [10:04] <zcorpan>  
> http://dvcs.w3.org/hg/html/file/f8b7e4633037/tests/submission/Ms2ger/dynamic-markup-insertion/document.open-02.html  
> - is w instanceof Window expected to work? shouldn't it be w instanceof  
> w.Window?
> # [10:04] <Ms2ger> Oh, good point
> # [10:05] <zcorpan>  
> http://dvcs.w3.org/hg/html/file/f8b7e4633037/tests/submission/Ms2ger/dynamic-markup-insertion/document.write-02.html  
> has an // XXX
> # [10:06] <Ms2ger> An incorrect XXX at that
> # [10:06] <Ms2ger> and -ln-02 as well, I guess
> # [10:07] <zcorpan> yah
> # [10:07] <Ms2ger> At least I'm consistent :)
> # [10:11] <zcorpan>  
> http://dvcs.w3.org/hg/html/file/f8b7e4633037/tests/submission/Ms2ger/dynamic-markup-insertion/innerhtml-03.xhtml  
> shouldn't the span have xmlns?
> # [10:12] <Ms2ger> Looks like it
> # [10:13] <zcorpan> also, getting innerHTML in xml isn't defined to  
> return only one possible string
> # [10:13] <zcorpan> it'd be conforming to use single quotes etc
> # [10:14] <zcorpan> i think that's a bug in the spec, but until the spec  
> is fixed...
> # [10:16] <zcorpan>  
> http://dvcs.w3.org/hg/html/file/f8b7e4633037/tests/submission/Ms2ger/dynamic-markup-insertion/innerhtml-01.xhtml  
> could be testing all listed cases that should throw
> # [10:16] <Ms2ger> It could be, if I had time :)
>
>
> I'll wait with approving until the comments are addressed.

# [10:23] <Ms2ger> I pushed http://dvcs.w3.org/hg/html/rev/d46205148900

Approved the tests in the above-mentioned folders.


>> Thanks
>> Ms2ger
>>
>> [1] http://dvcs.w3.org/hg/html/file/tip/tests/submission/Ms2ger
>
>


-- 
Simon Pieters
Opera Software
Received on Friday, 19 August 2011 08:23:55 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Friday, 19 August 2011 08:23:56 GMT