W3C home > Mailing lists > Public > public-html-testsuite@w3.org > June 2010

Bugs in the submitted foreign content tests

From: Ms2ger <ms2ger@gmail.com>
Date: Tue, 29 Jun 2010 20:59:49 +0200
Message-ID: <4C2A42A5.4060303@gmail.com>
To: Kris Krueger <krisk@microsoft.com>
CC: "public-html-testsuite@w3.org" <public-html-testsuite@w3.org>
Dear Kris

There are some bugs in the foreign content tests Microsoft submitted:


<http://dvcs.w3.org/hg/html/raw-file/54697709a218/tests/submission/Microsoft/foreigncontent/foreign_content_002.html>
The baseline of the text is to be placed at 0 pixels from the top of the 
svg element, [1][2] so "FillerText" is hidden. A solution would be to 
change

   var svgNamespace = "http://www.w3.org/2000/svg";
   var textElem = document.createElementNS(svgNamespace, "text");

to

   var svgNamespace = "http://www.w3.org/2000/svg";
   var textElem = document.createElementNS(svgNamespace, "text");
   textElem.setAttribute("y", "1em");


<http://dvcs.w3.org/hg/html/raw-file/54697709a218/tests/submission/Microsoft/foreigncontent/foreign_content_012.html>
Given that the UA style sheet for SVG is to contain |svg:not(:root) { 
overflow: hidden }|, [3] the bottom half of the second square is cut 
off, because it has been positioned outside of the svg element. To avoid 
confusion when interpreting the pass condition ("…above a black 
square.") strictly, I suggest changing

   <svg width="200px" height="200px">
       <rect id="rect1" x="0" y="0" width="100px" height="100px" />
       <rect id="rect2" x="0" y="150"  width="100px" height="100px" />
   </svg>

to

   <svg width="200px" height="200px">
       <rect id="rect1" x="0" y="0" width="100px" height="100px" />
       <rect id="rect2" x="0" y="100" width="100px" height="100px" />
   </svg>

to ensure the entire square is visible.


<http://dvcs.w3.org/hg/html/raw-file/54697709a218/tests/submission/Microsoft/foreigncontent/foreign_content_014.html>
<http://dvcs.w3.org/hg/html/raw-file/54697709a218/tests/submission/Microsoft/foreigncontent/foreign_content_015.html>
HTML5 does not require that SVG elements implement the id IDL attribute. 
To limit the test to what it claims to test, change

   var idName = parentNode.childNodes[i].id;

to

   var idName = parentNode.childNodes[i].getAttribute("id");


A patch with the suggested changes is attached.

[1] http://www.w3.org/TR/SVG/text.html#TSpanElementYAttribute
[2] http://www.w3.org/TR/SVG/text.html#AlignmentPoint
[3] http://lists.w3.org/Archives/Public/public-svg-wg/2008JulSep/0347.html


Received on Tuesday, 29 June 2010 19:00:18 GMT

This archive was generated by hypermail 2.2.0+W3C-0.50 : Tuesday, 29 June 2010 19:00:20 GMT