For (B), I wasn't suggesting that there be two different tests in one file, I was suggesting that we put operations like license requests into utils files that would perform either DRMToday or ClearKey license requests. For DRMToday, the implementation in these utils files would make the request to the actual DRMToday license server. For ClearKey, the implementation would likely return a response message that is placed into the test configuration JSON (drmconfig.json in the example test created by Sukhmal). The JSON config file can help configure both the key system and the desired license response message that we need in order to properly execute the test.
G
On 7/20/16, 1:30 PM, "Mark Watson" <watsonm@netflix.com<mailto:watsonm@netflix.com>> wrote:
So, what we have right now is:
(1) A large number of ClearKey-only tests in a "Google" folder, and
(2) One of those tests (basic playback) migrated to DRM Today, in the root folder
There are two approaches:
(A) Keep ClearKey and DRM tests separate: move the "Google" tests into the root or a "clearkey" folder, continue making new DRMToday versions of each of those ClearKey tests
(B) Make the DRMToday test also support ClearKey, continue making new ClearKey+DRMToday versions of each of the Google tests and, eventually, drop the Google folder
For (B), we need to run two tests in one file, which requires some care with async tests and there's been comments that we should not have multiple tests in one file.
Opinions ?
...Mark
On Wed, Jul 20, 2016 at 11:27 AM, Greg Rutz <G.Rutz@cablelabs.com<mailto:G.Rutz@cablelabs.com>> wrote:
I think the test utilities should be designed to be as DRM-independent as possible. This would allow us to run any of the test cases that apply to ClearKey simply by providing a DRMConfig and test content that indicates use of ClearKey. I apologize that I have not been following the EME spec progression that much over the last 12-18 months, but I recall there not being a ton of differences between ClearKey support and other DRMs as I implemented it in dash.js.
For test cases that are valid for ClearKey, the test case would simply execute multiple times on the UA under test - once with ClearKey content and one or more additional times for the "real" DRMs that are to be tested on that UA. No sense in maintaining separate test code if we don't have to.
G
On 7/20/16, 10:34 AM, "Mark Watson" <watsonm@netflix.com<mailto:watsonm@netflix.com>> wrote:
Question: should we expand this test case to cover ClearKey ? Or will we rely on the tests in the Google folder for ClearKey ?
If the latter, should we move those tests into the main directory (I see they are now working) ? Or, if others would like to add ClearKey tests, should they add them to the Google folder ?
...Mark
On Tue, Jul 19, 2016 at 7:18 PM, Mark Watson <watsonm@netflix.com<mailto:watsonm@netflix.com>> wrote:
All,
Sukhmal has created a Pull Request for a temporary session test case using DRM Today. We have tested this on Chrome with Widevine and it should work on Edge with PlayReady as well:
https://github.com/w3c/web-platform-tests/pull/3313
Please review this and comment on whether it is a good template / model for us to work from. We can quickly migrate more of the Google clearkey tests to drmtoday as well as implementing tests for other session types based on this model.
...Mark