Re: [geometry] Review request from Kari Pihkala on 2014-05-30 (public-fx@w3.org from April to June 2014)

From: Kari Pihkala <kari.pihkala@gmail.com>
Date: Fri, 30 May 2014 13:01:24 +0300
To: FX <public-fx@w3.org>
Message-ID: <CAE0t3Mw2qop5nsD=6MjAC27ZzKGB+reMZwAJoCDZkZPWgziXhA@mail.gmail.com>

I think there are few exception cases missing in the DOMMatrix:

 - SVGMatrix.rotateFromVector() can raise an exception, should
DOMMatrix.rotateFromVector() and rotateFromVectorBy() also raise
exceptions if values are invalid?
 - DOMMatrix.inverse() raises an exception if the matrix is
non-invertible, should DOMMatrix.invert() also do it?
 - can DOMMatrix.rotateAxisAngle() and rotateAxisAngleBy() fail? What
if x, y, and z are zero?

BR,
Kari

Received on Friday, 30 May 2014 10:01:52 UTC