W3C home > Mailing lists > Public > public-device-apis@w3.org > December 2015

RE: [battery] getBattery() test case feedback

From: Zhang, Zhiqiang <zhiqiang.zhang@intel.com>
Date: Fri, 4 Dec 2015 08:00:05 +0000
To: "Kostiainen, Anssi" <anssi.kostiainen@intel.com>, "Dominique Hazael-Massieux" <dom@w3.org>
CC: James Graham <james@hoppipolla.co.uk>, W3C Device APIs WG <public-device-apis@w3.org>, "ms2ger@gmail.com" <ms2ger@gmail.com>
Message-ID: <0EA8FB2070816C499E0A50AC1B0B5C163ACA3E16@SHSMSX101.ccr.corp.intel.com>
Hi,

> From: Kostiainen, Anssi
> Sent: Wednesday, November 18, 2015 7:43 PM
> 
> > On 18 Nov 2015, at 13:13, Dominique Hazael-Massieux <dom@w3.org>
> wrote:
> >
> > On 28/08/2015 08:55, Zhang, Zhiqiang wrote:
> >>> I'm wondering whether the testharness.js built-in promise_*() are of
> >>> any help or whether we'd need to patch testharness.js to add
> >>> support. I'd guess testharness.js should be able to properly test
> functions that return promises.
> >>> jgraham who's the original author of testharness.js was on the Moz
> >>> bug, perhaps he knows.
> >>
> >> Hmm, seems this is a problem of idlharness.js rather than
> >> testharness.js, as the idlharness.js hasn't considered the Promise related
> tech.
> >
> > I have a pending pull request on idlharness that I think would help  (at least
> a bit) with this:
> > https://github.com/w3c/testharness.js/pull/161

This pull request is no acceptable per Ms2ger and my review.

> 
> Dom - excellent, thank you!
> 
> My expectation is Zhiqiang will revise the Battery Status API test suite and
> provide feedback, when the testharness.js PR has landed.

I just have a quick testing on Firefox Nightly and Chrome, and make a test report at

https://w3c.github.io/test-results/battery-status/all.html

... for your info.

I also make a pull request at

https://github.com/w3c/web-platform-tests/pull/2412

... to deprecate battery-created-manual.html, which is only useful on devices that expose the BatteryManager
interface, but lack a backend implementation. This test is no longer needed, because at least we have 2
implementations now, Chrome and Firefox Nightly.

Please take a look at it.

Thanks,
Zhiqiang
Received on Friday, 4 December 2015 08:01:36 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 14:54:07 UTC