W3C home > Mailing lists > Public > public-device-apis@w3.org > March 2014

Re: Resolving DAP HTML Media Capture pull request review comment

From: Tobie Langel <tobie.langel@gmail.com>
Date: Sat, 8 Mar 2014 00:55:01 +0100
Cc: public-device-apis@w3.org
Message-Id: <20CC2663-5C55-4ACF-9B8F-DF952BF79961@gmail.com>
To: Frederick.Hirsch@nokia.com
Hi Frederick,

Thanks for the email.

On 07 Mar 2014, at 20:53, <Frederick.Hirsch@nokia.com> <Frederick.Hirsch@nokia.com> wrote:
> I notice you had some comment on the DAP HTML Media Capture pull request regarding SHOULD requirements [1] . I believe the thread resulted in a conclusion of adding metadata in conjunction with the  SHOULDs. Did this resolve your concern with the Pull request? Do you think it can be approved now?

I went back over the thread right now, and unfortunately, no conclusion seamed to have been reached.

In this regard, I suggest someone else from the DAP WG should just review this test and decide (maybe in conjunction with the rest of the group) whether or not testing SHOULD requirements is appropriate in this case.

> Do you have any comment on any of the other Pull requests [2] ?

I don't, but I'm glad you're making good use of the auto-tagging feature of the repository.

> I notice that all of the pull requests have a default critic list of  "Simon Pieters, Masataka Yakura, xiaoqian, Anne van Kesteren, James Graham”, but that we have not seen comment for a number of months. Is this a reasonable critic list (or is it a pull system default)?

I have no idea how Critic works or how it picks reviewers; I find GH Issues to be good enough for most use cases including ours.

I had planned automatically adding reviewers to pull requests (based on a spec metadata described here[1]) as part of the auto-tagging tool, but unfortunately funds run out before I was able to get to it.

Best,

--tobie

---
[1]: http://testthewebforward.org/docs/migration-process.html#spec-metadata
Received on Friday, 7 March 2014 23:55:31 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 14:54:02 UTC