W3C home > Mailing lists > Public > public-device-apis@w3.org > June 2014

Re: [battery] Battery Editors Draft update needed to prepare for LC

From: Tim Volodine <timvolodine@google.com>
Date: Mon, 9 Jun 2014 18:17:40 +0100
Message-ID: <CAJv4RS0x81qOBUaYkTNKfubSqpUa_jR0ofQZGaTArB3JRXWFLQ@mail.gmail.com>
To: "Kostiainen, Anssi" <anssi.kostiainen@intel.com>, Mounir Lamouri <mounir@lamouri.fr>
Cc: "cathy.chan@nokia.com" <cathy.chan@nokia.com>, W3C APIs WG Device <public-device-apis@w3.org>
a few more comments:

section 1, example 2:
An extra call to updateTimer(battery) once the promise resolves would
probably be better. Otherwise the updateTimer is only called when the
battery actually changes (and not at resolve time). This also applies to
Examples 3 and 4.

section 5, the steps after getBattery() is invoked should mention the case
when the getBattery() method is invoked for a second time while the first
promise has not resolved yet.

section 6, in the sentence: "When a BatteryManager object is created..."
should say that "if the implementation is unable to report *any* battery
information" the default values should be as stated.

section 6.1, multiple batteries:
replace: must -> should
level -- should use a weighted average in case batteries have different
capacities.
chargingTime -- depending on how the batteries are charged, sequentially or
in parallel this could be either a "sum" or "max".
dischargingTime -- "max" if the batteries a discharging in parallel or a
"sum" if in sequence (which is probably the more likely scenario).

thanks,
Tim



On Mon, Jun 9, 2014 at 3:12 PM, Kostiainen, Anssi <
anssi.kostiainen@intel.com> wrote:

> On 09 Jun 2014, at 16:28, Kostiainen, Anssi <anssi.kostiainen@intel.com>
> wrote:
>
> > I moved all the descriptive text into its own paragraph after the IDL
> block:
> >
> > https://dvcs.w3.org/hg/dap/rev/65ff0151a2e5
>
> I should have said *above* the IDL block. Here’s a pointer to ease the
> review:
>
>
> https://dvcs.w3.org/hg/dap/raw-file/default/battery/Overview.html#batterymanager-interface
>
> Thanks,
>
> -Anssi
>
>
>
Received on Monday, 9 June 2014 17:18:29 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 14:54:03 UTC