W3C home > Mailing lists > Public > public-device-apis@w3.org > February 2014

[testing] Pull request status and questions for proximity, light, battery, html media capture

From: <Frederick.Hirsch@nokia.com>
Date: Thu, 20 Feb 2014 23:07:56 +0000
To: <public-device-apis@w3.org>
CC: <Frederick.Hirsch@nokia.com>
Message-ID: <5F1ABBFF-938E-417F-A23F-F6B7245CDAC6@nokia.com>
This message is about the status of the four open pull requests directly related to DAP, not including those that the Media Capture Task Force is handling.
I note a few questions below.

See https://github.com/w3c/web-platform-tests/issues?labels=wg-dap

———

The four pull requests are 

#398,  proximity: Add more tests for Proximity Events proximity wg-dap
		• Opened by zqzhang 4 months ago,  1 comment
		added  IDL tests, Initial value tests; TypeError tests update

#395,  light: Add more test cases for Ambient Light Events ambient-light wg-dap
		• Opened by zqzhang 4 months ago, •  2 comments
	Add idlharness.html using idlharness.js, Add LightLevelEvent_tests.js for LightLevelEvent interface
	Rename DeviceLight_tests.js to DeviceLightEvent_tests.js and update it a little
	Rename DeviceLight_tests.html to AmbientLight_tests.html to include LightLevelEvent_tests.js
      Add more test cases for Ambient Light Events …	a7898aa
	Remove manifest under ambient-light and address change in #518

#376, battery: Submission/ldeluca battery-status wg-dap
		• Opened by ldeluca 4 months ago, •  1 comment
	added missing tests for battery test spec. formatting

#306, html media capture: Created tests for http://www.w3.org/TR/html-media-capture/html-media-capture wg-dap
	• Opened by zqzhang 6 months ago, •  2 comments
	Created tests for http://www.w3.org/TR/html-media-capture/
	Update idlharness tests to reflect #388 cleanup	ba9b637

——

All four pull requests have a critic comment that says "waiting for review from Simon Pieters, Masataka Yakura, xiaoqian, Anne van Kesteren, James Graham"

Question: These have all been open for months so I wonder if this is the right reviewer list or if there is another reason no review comments are noted?

——

On battery,  zqzhang  notes:

Better to put this into battery-interface.html as specification link.

See Specification Links in http://testthewebforward.org/docs/test-templates.html#template-details

chargingTime has been checked in battery-charging-manual.html, battery-created.html, battery-discharging-manual.html and battery-full.html

another, better to use assert_true

level has been checked in battery-charging-manual.html, battery-created.html, battery-discharging-manual.html and battery-full.html

Question : how does this affect the edits reflected in the pull request, are additional edits needed?

——

HTML Media Capture, zqzhang

Tobie comment thread on normative/informative and SHOULD leading to:

zqzhang added some commits 5 months ago
	Add meta data flags to reflect SHOULD requirements …	5681ce4

Question: Does that close out Tobie's issue?

===

If anyone in DAP can volunteer to help review and close out these pull requests please indicate so on the list. Also, if anyone is familiar with the detailed status on these items please let me know so we do not do re-work.

I suggest we add this topic to the agenda for next week’s call.

Thanks

regards, Frederick

Frederick Hirsch, Nokia
Chair, W3C DAP Working Group
Received on Thursday, 20 February 2014 23:09:28 UTC

This archive was generated by hypermail 2.3.1 : Monday, 23 October 2017 14:54:02 UTC