W3C home > Mailing lists > Public > public-device-apis-log@w3.org > May 2019

Re: [wake-lock] Losing reference to a WakeLock object is a bug or intended behavior (#199)

From: Marcos Cáceres via GitHub <sysbot+gh@w3.org>
Date: Wed, 01 May 2019 04:55:53 +0000
To: public-device-apis-log@w3.org
Message-ID: <issue_comment.created-488210588-1556686552-sysbot+gh@w3.org>
> my opinion is that this is not an issue which the specification should attempt to resolve as it adds unnecessary complexity.

Strongly agree. Also agree that we should drop `query()`, `abort()`, and support throwing the `InvalidStateError`. 

> Otherwise I would recommend removing the WakeLock object entirely and reverting to a static request() method that only supports cancellation via an AbortSignal.

I'm also leaning towards this. It's much more sane. 



-- 
GitHub Notification of comment by marcoscaceres
Please view or discuss this issue at https://github.com/w3c/wake-lock/issues/199#issuecomment-488210588 using your GitHub account
Received on Wednesday, 1 May 2019 04:55:55 UTC

This archive was generated by hypermail 2.3.1 : Wednesday, 1 May 2019 04:55:55 UTC