- From: Anssi Kostiainen via GitHub <sysbot+gh@w3.org>
- Date: Thu, 17 Jan 2019 10:07:57 +0000
- To: public-device-apis-log@w3.org
Thanks @Honry! Since the contents of this PR has already been reviewed in #369 I'll just focus my comments on how to possibly split test automation spec bits across specs. All - would you prefer to see mock sensor types ([sections 9.1.3.*](https://pr-preview.s3.amazonaws.com/Honry/sensors/pull/377.html#mock-ambient-light-sensor)) integrated into corresponding concrete sensor specs? That might make maintenance easier if/when those specs add new API surface that need to be accompanied with corresponding new mock sensor reading values. Also, to acknowledge @Honry's contributions to testing and automation and make it clear to folks who to contact for testing related bits in the spec, I'd suggest adding the following to the headers: ``` !Test Facilitator: Wanming Lin (Intel Corporation) ``` -- GitHub Notification of comment by anssiko Please view or discuss this issue at https://github.com/w3c/sensors/pull/377#issuecomment-455115404 using your GitHub account
Received on Thursday, 17 January 2019 10:08:11 UTC