Re: CR: Generating JSON from Tabular Data on the Web

Jeremy Tandy wrote:
> I believe that I have resolved the concerns that you raised (we captured
> this in GitHub ISSUE #679 [1]). Please refer to PULL REQUEST #751 [2] for
> details (this contains fixes for both CSV2RDF and CSV2JSON).
>
> I've checked through to ensure use of en-us spelling.

thanks

> I have also, I hope, fixed recurring examples of the issues you raised once.

thanks

> Two points to raise.
>
> First, in CSV2JSON, you suggested that the definition of "Root" should be
> modified from "child of any vertex" to "child of another vertex". As
> identified by David Booth in his email [3], I think the original was
> correct.

I was identifying that `any` felt awkward (specifically the idea that
someone would think about the root and itself, which is presumably an
element included by `any vertex`). I made a suggestion, which was
probably the wrong suggestion.

> No change was made.

I think "any other" would probably be better than "any".

> Second, you asked why, in the example below, "B.B. King" was not quoted.
>
> example: http://example.org/events-listing.csv
> ```
>
> Name, Start Date, Location Name, Location Address, Ticket Url
> B.B. King,2014-04-12T19:30,"Lupo’s Heartbreak Hotel","79 Washington St.,
> Providence, RI",https://www.etix.com/ticket/1771656
> B.B. King,2014-04-13T20:00,"Lynn Auditorium","Lynn, MA,
> 01901",http://frontgatetickets.com/venue.php?id=11766
>
>
> ```
>
> Within tabular data, cells MAY be quoted - but do not have to be. Where the
> cell value includes the separator character (e.g. comma `,`), wrapping the
> cell value in quotes enables the cell value to be treated as a single item.
> Please refer to 'Parsing Tabular Data' [4] for more information.

Right. I'm not sure why I asked about it, it was a while ago. It's
probably because it was the *only* field (excluding the headings)
which had spaces that weren't quoted. If there was a second (non
heading) field value with spaces and no quotation marks, my reading
pass probably wouldn't have asked.

> Can you please confirm that you are content that the comments you raised in
> relation to CSV2JSON have been appropriately resolved?

I tried looking at the (web) diff, and I can't really figure out how
to use it to verify things -- find isn't working for me.

As I'm just trying to provide feedback, I'm going to trust that you
did a good job of incorporating it.

Received on Wednesday, 21 October 2015 16:40:01 UTC