Re: [css-writing-modes-3] [css-logical-properties-1] logicalprops-block-size test: resources/style-check.js found only in test.csswg.org/source/css-logical-properties-1

Thanks for reporting.  Will check why resources/style-check.js not located
properly.

2017-01-26 10:34 GMT+08:00 Gérard Talbot <css21testsuite@gtalbot.org>:

> Le 2017-01-25 21:08, Gérard Talbot a écrit :
>
>> Xu,
>>
>> http://test.csswg.org/harness/test/css-writing-modes-3_dev/s
>> ection/6.4/logicalprops-block-size/
>>
>> http://test.csswg.org/suites/css-writing-modes-3_dev/nightly
>> -unstable/html/logicalprops-block-size.htm
>>
>> 1-
>> Your test is now inserted, included in the Writing-modes test suite.
>> You have a link to writing-modes spec in it. I must point out a
>> problem with
>>
>> line 9: <script src="resources/style-check.js"></script>
>>
>> This script file exists in
>>
>> http://test.csswg.org/source/css-logical-properties-1/resources/
>>
>> but does not exist for
>>
>> http://test.csswg.org/source/css-writing-modes-3/
>>
>> Therefore, the call for compareWidthHeight will not be successful and
>> will generate a typical error:
>>
>> "
>> compareWidthHeight is not defined
>> ReferenceError: compareWidthHeight is not defined
>> "
>>
>> and also
>>
>> "
>> Failed to load resource: the server responded with a status of 404
>> (Not Found) style-check.js
>> "
>>
>> "
>> http://test.csswg.org/suites/css-writing-modes-3_dev/nightly
>> -unstable/html/resources/style-check.js
>>  HTTP/1.1 404 Not Found 89 ms
>> "
>>
>> in several browsers.
>>
>
> The same problem exists for your other 3 tests in that section:
>
>
> http://test.csswg.org/harness/test/css-writing-modes-3_dev/s
> ection/6.4/logicalprops-block-size-vlr/
>
> http://test.csswg.org/suites/css-writing-modes-3_dev/nightly
> -unstable/html/logicalprops-block-size-vlr.htm
>
>
> http://test.csswg.org/harness/test/css-writing-modes-3_dev/s
> ection/6.4/logicalprops-inline-size/
>
> http://test.csswg.org/suites/css-writing-modes-3_dev/nightly
> -unstable/html/logicalprops-inline-size.htm
>
>
> http://test.csswg.org/harness/test/css-writing-modes-3_dev/s
> ection/6.4/logicalprops-inline-size-vlr/
>
> http://test.csswg.org/suites/css-writing-modes-3_dev/nightly
> -unstable/html/logicalprops-inline-size-vlr.htm
>
>
>
> 2-
>> Your test seems to be doing basic support/checking of min-block-size,
>> max-block-size and, in part, inline-size for the 'horizontal-tb'
>> writing mode only. In my opinion, I think your logicalprops-block-size
>> test does not fit well or best with
>>
>> §6.4 Abstract-to-Physical Mappings
>> https://drafts.csswg.org/css-writing-modes-3/#logical-to-physical
>>
>
> Please ignore this comment. I am sorry. I just noticed that you had other
> tests testing vertical-lr. I was not aware of your other tests when I sent
> my previous email.
>
>
> Gérard
> --
> Test Format Guidelines
> http://testthewebforward.org/docs/test-format-guidelines.html
>
> Test Style Guidelines
> http://testthewebforward.org/docs/test-style-guidelines.html
>
> Test Templates
> http://testthewebforward.org/docs/test-templates.html
>
> CSS Naming Guidelines
> http://testthewebforward.org/docs/css-naming.html
>
> Test Review Checklist
> http://testthewebforward.org/docs/review-checklist.html
>
> CSS Metadata
> http://testthewebforward.org/docs/css-metadata.html
>



-- 
NaCl!