- From: Florian Rivoal <florian@rivoal.net>
- Date: Thu, 7 May 2015 00:04:56 +0200
- To: fantasai <fantasai.lists@inkedblade.net>
- Cc: "public-css-testsuite@w3.org" <public-css-testsuite@w3.org>
> On 06 May 2015, at 23:38, fantasai <fantasai.lists@inkedblade.net> wrote: > > On 04/28/2015 04:35 AM, Florian Rivoal wrote: >> Hi Scott, Fantasai and David, >> >> (Sending to you because you are marked in shepherd either as author or owner of the TCs) >> >> Since the box-sizing section of css3-ui has now stabilized, I've reviewed the test cases that Mozilla has contributed to the w3c for box-sizing. Sorry about the long delay between submission and review. >> >> http://test.csswg.org/shepherd/search/testcase/spec/css-ui-3/owner/dbaron >> >> While they are all correct, they also all need improvements. Most of the TC are not minimized and use quite a bit more markup and style than needed for what they are testing. They also use an unusual look for the PASS state, while they could easily be made into the typical 100*100px green square with no red. Also, they are not reftests even though they easily could be. >> >> See this comment on box-sizing-border-box-001 for a representative example of what I'm talking about: >> http://test.csswg.org/shepherd/testcase/box-sizing-border-box-001/spec/css-ui-3/owner/dbaron/#comment-432e47396122 > > In general I agree with your comments, however > >> 3) no need for black borders anywhere >> >> 4) no need for blue and green. All green for pass, some red for fail is more obvious > > I think that it helps to have borders that are visible and show what's going on. > (They could still be green, perhaps different shades of green, but should be visibly > distinct.) Now that we are using automated tests, it is not so critical for the test > result to be fast for a human to evaluate--instead, it is more important that a > developer reviewing the test or evaluating a failed result is able to understand > what's happening in the test. > > So, yes, have red for failures to make that obvious. But don't hide what's happening > in the test, if showing it does not make it more complicated than not showing it. Fair enough. I think old fashioned plain green box tests should still pass review, but more descriptive tests should now be fine as well. > Also, those tests should include both padding and borders, otherwise the UA could > have a bug with handling borders but not padding. r- fantasai for that. :) A few of the tests do include both. - Florian
Received on Wednesday, 6 May 2015 22:05:21 UTC