Re: [css-writing-modes-3] Review of new-text-baseline-00[2-9]

Gérard,

Thank you for reviewing.
submitted.
https://hg.csswg.org/test/rev/1141f8479940

Hajime.


2015-01-30 3:18 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:

> Le 2015-01-29 08:48, 塩澤 元 a écrit :
>
>> Gérard,
>>
>> - https://hg.csswg.org/test/rev/6d4fa9b7778c: applying review from you
>> (and
>> add two files which I forgot to submit)
>> - https://hg.csswg.org/test/rev/2ce6f2c1e864: renaming files
>> - https://hg.csswg.org/test/rev/a14ec72997ee: add your name as reviewer
>>
>> Please check above submit.
>>
>> Hajime.
>>
>
> Hajime,
>
> http://test.csswg.org/source/css-writing-modes-3/text-baseline-006-ref.xht
>
> 1-
> line 35:
> height="120" aalt="Image download
>
> aalt should be alt.
>
> 2-
> More compact code (replacement) for lines 8 to 26:
>
> img
>   {
>     padding-left: 54px;
>     vertical-align: top;
>   }
>
> -------
>
> http://test.csswg.org/source/css-writing-modes-3/text-baseline-007-ref.xht
>
> line 35:
> height="120" aalt="Image download
>
> aalt should be alt
>
> -------
>
> If you do all the above, then add
>
>  <link rel="reviewer" title="Gérard Talbot" href="http://www.gtalbot.org/
> BrowserBugsSection/css21testsuite/" /> <!-- 2015-01-29 -->
>
> to
>
> text-baseline-002-ref.xht
> text-baseline-006-ref.xht
> text-baseline-007-ref.xht
>
>
> Gérard
>
>
>  2015-01-26 11:19 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:
>>
>>  Le 2015-01-24 08:08, 塩澤 元 a écrit :
>>>
>>>  Gérard,
>>>>
>>>> I have applied your review to new-text-baseline test^cases
>>>> The changeset are
>>>> - https://hg.csswg.org/test/rev/5f452eec1fb2
>>>> - https://hg.csswg.org/test/rev/05c60304a1ec
>>>>
>>>> The summary of change is as follows:
>>>> - remove redeclared line-height
>>>> - specify unitless line-height (use 1.5)
>>>> - change font-size for largest character from 1.5em to 2em (it is
>>>> computed
>>>> 120px)
>>>> - specify 'height: 3em;'
>>>> - specify correct flag ('ahem' or 'image')
>>>> - remove unnecessary body selector (body {})
>>>> - change ref flies into using image (and add new swatch file,
>>>> swatch-fuchsia.png)
>>>>
>>>> Hajime.
>>>>
>>>>
>>> For all tests:
>>>
>>> http://test.csswg.org/source/css-writing-modes-3/new-text-
>>> baseline-00[2-9].xht
>>>
>>>
>>> Please remove the -webkit- prefix in all the
>>> new-text-baseline-00[2-9].xht
>>> tests.
>>>
>>> ---------
>>>
>>> http://test.csswg.org/source/css-writing-modes-3/new-text-
>>> baseline-006.xht
>>>
>>> http://test.csswg.org/source/css-writing-modes-3/new-text-
>>> baseline-008.xht
>>>
>>> and
>>>
>>> http://test.csswg.org/source/css-writing-modes-3/new-text-
>>> baseline-009.xht
>>>
>>> <p>Test passes if there is a pink polygon and if its left vertical edge
>>> is
>>> straight, uniform and unbroken.</p>
>>>
>>> could also be trimmed without loss of meaning. I suggest:
>>>
>>> <p>Test passes if the <strong>left edge</strong> of an irregular polygon
>>> is straight and unbroken.</p>
>>>
>>> ---------
>>>
>>> http://test.csswg.org/source/css-writing-modes-3/new-text-
>>> baseline-007.xht
>>>
>>> I suggest:
>>>
>>> <p>Test passes if the <strong>right edge</strong> of an irregular polygon
>>> is straight and unbroken.</p>
>>>
>>> Another idea would be to change color, like olive color, so that testers
>>> would not be lead to associate an irregular pink polygon to the left
>>> side.
>>>
>>> --------
>>>
>>>  Eventually I will remove the old version text-baseline-*.xht and
>>>
>>>> replace it with 'new-text-baseline-*.xht'.
>>>>
>>>>
>>> Will you rename the new-text-baseline-*.xht as text-baseline-*.xht now?
>>> Was it your initial intent to eventually rename them as
>>> text-baseline-*.xht
>>> ?
>>>
>>> --------
>>>
>>> If you do all of the above and then add
>>>
>>> <link rel="reviewer" title="Gérard Talbot" href="http://www.gtalbot.org/
>>> BrowserBugsSection/css21testsuite/" /> <!-- 2015-01-25 -->
>>>
>>> Gérard
>>>
>>>
>>>  2015-01-18 2:54 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:
>>>
>>>>
>>>>  Le 2015-01-11 10:59, 塩澤 元 a écrit :
>>>>
>>>>>
>>>>>  A Changeset is https://hg.csswg.org/test/rev/f2c0e42b53ad.
>>>>>
>>>>>>
>>>>>> 2015-01-11 23:36 GMT+09:00 塩澤 元 (Shiozawa, Hajime) <
>>>>>> hajime.shiozawa@gmail.com>:
>>>>>>
>>>>>>  Gérard,
>>>>>>
>>>>>>
>>>>>>> I have submitted the new version text-baseline-* tests as
>>>>>>> 'new-text-baseline-*.xht'
>>>>>>> Eventually I will remove the old version text-baseline-*.xht and
>>>>>>> replace
>>>>>>> it with 'new-text-baseline-*.xht'.
>>>>>>> Also I have created ref files for these testcases.
>>>>>>> (new-text-baseline-002-ref.xht, new-text-baseline-006-ref.xht,
>>>>>>> new-text-baseline-007-ref.xht)
>>>>>>> Could you review it?
>>>>>>>
>>>>>>>
>>>>>>>   Hajime,
>>>>>>
>>>>>
>>>>>
>>>>> http://test.csswg.org/suites/css-writing-modes-3_dev/
>>>>> nightly-unstable/html/new-text-baseline-00[2-9].htm
>>>>>
>>>>> 1-
>>>>> redeclared line-height
>>>>> ----------------------
>>>>>
>>>>> In many new-text-baseline-00[2-9] tests, you have around lines 14, 15:
>>>>>
>>>>>       font: 3.75em/1.5 Ahem; /* computes to 60px/90px */
>>>>>       line-height: 1.5em;
>>>>>
>>>>> I suggest to use
>>>>>
>>>>> font: 3.75em/1.5em Ahem; /* computes to 60px/90px */
>>>>>
>>>>> and to not redeclare, to not redefine line-height.
>>>>>
>>>>> Or you could split the font shorthand property into:
>>>>>
>>>>> font-size: 3.75em;
>>>>> font-family: Ahem;
>>>>> line-height: 1.5em;
>>>>>
>>>>>
>>>>> 2-
>>>>> Unitless line-height value
>>>>> --------------------------
>>>>>
>>>>> Personally, I usually make the line box height wider(taller) than the
>>>>> widest(tallest) character so that I can also check if characters are
>>>>> properly laid out, accurately positioned into the line box. This makes
>>>>> the
>>>>> test a bit more difficult to pass: what I do here is to enlarge the
>>>>> corridor of failure. So, that's why I use 'line-height: 1.5' or
>>>>> 'line-height: 2' or 'line-height: 3' . eg:
>>>>>
>>>>> http://test.csswg.org/suites/css-writing-modes-3_dev/
>>>>> nightly-unstable/html/central-baseline-alignment-002.htm
>>>>>
>>>>> With line-height: 1.5em, the line-box width will be exactly as
>>>>> wide(tall)
>>>>> as its blue square and therefore it will be flush with the document box
>>>>> left content edge.
>>>>>
>>>>> 3-
>>>>> leading minus content area dividable by 2
>>>>> -----------------------------------------
>>>>>
>>>>> By the way, I changed
>>>>> span#ninety
>>>>>     {
>>>>>       font-size: 1.5em; /* computes to 90px */
>>>>>     }
>>>>>
>>>>> to
>>>>>
>>>>>   span#blue120
>>>>>     {
>>>>>       color: blue;
>>>>>       font-size: 2em; /* computes to 120px */
>>>>>     }
>>>>>
>>>>> in my tests
>>>>> (eg
>>>>> http://test.csswg.org/suites/css-writing-modes-3_dev/
>>>>> nightly-unstable/html/central-baseline-alignment-002.htm
>>>>> )
>>>>> because with 'font-size: 1.5em', the leading is not dividable by 2
>>>>> (without a remainer):
>>>>>
>>>>> font-size: 1.5em; /* computes to 90px */
>>>>> line-height: 1.5; /* computes to 135px */
>>>>> /* line-height is inherited by inlines */
>>>>>
>>>>> 135px is not dividable by 2 but 180px will be dividable by 2!
>>>>>
>>>>> "
>>>>> for absolute reliability, the difference between computed line-height
>>>>> and
>>>>> computed font-size should be dividable by 2.
>>>>> "
>>>>> Ahem Usage
>>>>> http://testthewebforward.org/docs/test-style-guidelines.
>>>>> html#special-fonts
>>>>>
>>>>> 4-
>>>>> 'height: auto'
>>>>> --------------
>>>>>
>>>>> http://test.csswg.org/suites/css-writing-modes-3_dev/
>>>>> nightly-unstable/html/new-text-baseline-00[2-9].htm
>>>>>
>>>>> In your new-text-baseline-00[2-9].htm , the tested div must have a set
>>>>> height otherwise a vertical scrollbar should be, must be generated by
>>>>> compliant browsers. That's because computed height of 'height: auto'
>>>>> will
>>>>> be the height of viewport. And since the pass-fail conditions sentence
>>>>> uses
>>>>> 52px, then it will exceed the height of viewport. Chrome fails to honor
>>>>> accordingly 'height: auto'; Firefox honors 'height: auto' for block
>>>>> boxes.
>>>>>
>>>>> I suggest 'height: 3em' for your new-text-baseline-00[2-9] tests
>>>>>
>>>>> 5-
>>>>> <meta name="flags" content="image">
>>>>>
>>>>> http://test.csswg.org/suites/css-writing-modes-3_dev/
>>>>> nightly-unstable/html/new-text-baseline-002.htm
>>>>>
>>>>> It should be instead
>>>>>
>>>>> <meta name="flags" content="ahem">
>>>>>
>>>>> 6-
>>>>>     body {
>>>>>
>>>>>     }
>>>>>
>>>>> should be removed.
>>>>>
>>>>> 7-
>>>>>
>>>>> http://test.csswg.org/suites/css-writing-modes-3_dev/
>>>>> nightly-unstable/html/reference/new-text-baseline-002-ref.htm
>>>>>
>>>>> The reference file should be using only images, support images.
>>>>>
>>>>> Please see, consult
>>>>>
>>>>> http://test.csswg.org/suites/css-writing-modes-3_dev/
>>>>> nightly-unstable/html/reference/central-baseline-alignment-002-ref.htm
>>>>>
>>>>> as an example.
>>>>>
>>>>> Gérard
>>>>> --
>>>>> Test Format Guidelines
>>>>> http://testthewebforward.org/docs/test-format-guidelines.html
>>>>>
>>>>> Test Style Guidelines
>>>>> http://testthewebforward.org/docs/test-style-guidelines.html
>>>>>
>>>>> Test Templates
>>>>> http://testthewebforward.org/docs/test-templates.html
>>>>>
>>>>> CSS Naming Guidelines
>>>>> http://testthewebforward.org/docs/css-naming.html
>>>>>
>>>>> Test Review Checklist
>>>>> http://testthewebforward.org/docs/review-checklist.html
>>>>>
>>>>> CSS Metadata
>>>>> http://testthewebforward.org/docs/css-metadata.html
>>>>>
>>>>>
>>>>>
>>>>>  --
>>> Test Format Guidelines
>>> http://testthewebforward.org/docs/test-format-guidelines.html
>>>
>>> Test Style Guidelines
>>> http://testthewebforward.org/docs/test-style-guidelines.html
>>>
>>> Test Templates
>>> http://testthewebforward.org/docs/test-templates.html
>>>
>>> CSS Naming Guidelines
>>> http://testthewebforward.org/docs/css-naming.html
>>>
>>> Test Review Checklist
>>> http://testthewebforward.org/docs/review-checklist.html
>>>
>>> CSS Metadata
>>> http://testthewebforward.org/docs/css-metadata.html
>>>
>>>
>>>
> --
> Test Format Guidelines
> http://testthewebforward.org/docs/test-format-guidelines.html
>
> Test Style Guidelines
> http://testthewebforward.org/docs/test-style-guidelines.html
>
> Test Templates
> http://testthewebforward.org/docs/test-templates.html
>
> CSS Naming Guidelines
> http://testthewebforward.org/docs/css-naming.html
>
> Test Review Checklist
> http://testthewebforward.org/docs/review-checklist.html
>
> CSS Metadata
> http://testthewebforward.org/docs/css-metadata.html
>



-- 
# 塩澤 元 (Shiozawa, Hajime)
# mail: hajime.shiozawa@gmail.com