- From: Gérard Talbot <css21testsuite@gtalbot.org>
- Date: Sun, 11 Jan 2015 19:02:59 -0500
- To: 塩澤 元 (Shiozawa, Hajime) <hajime.shiozawa@gmail.com>
- Cc: Public CSS Test suite mailing list <public-css-testsuite@w3.org>, Elika 'fantasai' Etemad <fantasai@inkedblade.net>, Koji Ishii <kojiishi@gluesoft.co.jp>
Le 2015-01-11 03:22, 塩澤 元 a écrit : > Gérard, > > I have submitted 'direciton: rtl' version. > http://hg.csswg.org/test/rev/77111522a3b0 > > Please review these test-cases. http://test.csswg.org/source/css-writing-modes-3/row-progression-011.xht http://test.csswg.org/source/css-writing-modes-3/row-progression-012.xht http://test.csswg.org/source/css-writing-modes-3/row-progression-013.xht http://test.csswg.org/source/css-writing-modes-3/row-progression-014.xht http://test.csswg.org/source/css-writing-modes-3/row-progression-015.xht http://test.csswg.org/source/css-writing-modes-3/row-progression-016.xht http://test.csswg.org/source/css-writing-modes-3/row-progression-017.xht http://test.csswg.org/source/css-writing-modes-3/row-progression-018.xht Hajime, I think those tests should not be using 'unicode-bidi'... unless you want to specifically test directionality of text inside table cells. I think your tests - without use of 'unicode-bidi' - should be about *_table column ordering_*; how 'direction:rtl' set on a table element affects table column order. When you read the spec and a testable statement of the spec, you want to create a test that will check one and one single aspect of the spec and one and only one statement of the spec. And you want to create filenames for test and test assertion text that will be coherent. When I now rethink this, I do not see how we could create more tests or other tests regarding table rows progression. By definition, 'direction: rtl' and 'unicode-bidi: bidi-override' are not supposed to have any impact, any rendering effect on table row progression to begin with! But 'direction: rtl' should have an impact, a rendering effect on columns order. Are your 'row-progression-01[1-8].xht' tests a waste of time? No. They should probably a) be filename-renamed b) with new <title> and c) with new text assert and check how 'unicode-bidi: override' does to text directionality in table cells and another version of those same 'row-progression-01[1-8].xht' tests should be about table column order. I'll try to create an example of this later. Gérard > 2015-01-07 23:39 GMT+09:00 塩澤 元 (Shiozawa, Hajime) < > hajime.shiozawa@gmail.com>: > >> Hi Gérard, >> >> I have reviewed 'row-progression-00[2~9].xht'. >>>> I feel that it is need to add 'direction: rtl' version of these >>>> testcases. >>>> >>>> Now I'm thinking about creating 'direction: rtl' version of these >>>> testcases. >>>> >>> >>> Okay, go ahead. Create 'direction: rtl' version of >>> row-progression-00[2-9].xht tests. >>> >> >> OK, I'm going to create 'direciton: rtl' version of tests. >> I will submit 'direction: rtl' version of tests on this weekend. >> >> -- >> # 塩澤 元 (Shiozawa, Hajime) >> # mail: hajime.shiozawa@gmail.com >> -- Test Format Guidelines http://testthewebforward.org/docs/test-format-guidelines.html Test Style Guidelines http://testthewebforward.org/docs/test-style-guidelines.html Test Templates http://testthewebforward.org/docs/test-templates.html CSS Naming Guidelines http://testthewebforward.org/docs/css-naming.html Test Review Checklist http://testthewebforward.org/docs/review-checklist.html CSS Metadata http://testthewebforward.org/docs/css-metadata.html
Received on Monday, 12 January 2015 00:03:37 UTC