Re: CSS Grid Layout tests suite

Hi again,

On 27/10/14 16:12, Gérard Talbot wrote:
>>> I can make some comments on 1 test (randomly chosen). I understand you
>>> are not the author of such test... and it appears that those tests were
>>> based on an outdated version of the spec.
>>
>> Yes, you're right, I'm not the author and they're outdated.
>> Thanks for the review, I agree with all of your comments.
>>
>> However, as I'm not the author, I don't know what's the best approach to
>> carry on.
> 
> Normally, someone (the test reviewer) would try to contact/email the
> original author so that these issues would be fixed, corrected.
> 
>> I'm just wondering if it'd be a better idea to start from scratch with
>> new tests, that will replace the current ones step by step once the new
>> tests are reviewed and integrated.
> 
> If the tests were based on an outdated version of the spec, then it may
> be better to start from scratch with new tests.

Yeah, I understand the regular workflow.

> I expect that I will not be able to review tests for the next 4-5 months
> or so. The good news is that I took a lot of notes since 2010 when
> reviewing tests and created a document that you can read. Such document
> lists all kinds of code situations I met when reviewing tests. The
> document is basically how to improve test design, what to avoid, what's
> good to do, what's better, etc.. It's a more advanced test writing
> guidelines kind-of-document.

It'd be nice if we could find someone else to help us with the review,
at least during the initial phase.
Otherwise we'll try to follow your advices and do our best :-)

> A first draft was made public in:
> 
> 28 proposals to improve testcase writing guidelines
> http://lists.w3.org/Archives/Public/public-css-testsuite/2011Dec/0004.html
>
> Since then, I have improved such document; it's more detailed and lists
> additional improvements.

Thanks for the link, it has a good set of really useful rules.
It'd be great to have that document in a wiki or directly under
http://testthewebforward.org/docs/.

Cheers,
  Rego

Received on Tuesday, 28 October 2014 14:15:50 UTC