Re: [css-writing-mode] full-width-002 and != full-width-horizontal-notref

Gérard,

Sorry for replying you late. I've been down for the past few days...

Looking at the file and I finally got the point. Yes, you're right. I was
somehow completely misunderstood.

I've applied your suggested fix and sent a pull request to GitHub. Thanks!

On Thu Nov 13 2014 at 6:49:24 AM Gérard Talbot <css21testsuite@gtalbot..org>
wrote:

> Le 2014-11-09 01:18, Gérard Talbot a écrit :
> > Masataka,
> >
> > http://test.csswg.org/suites/css-writing-modes-3_dev/
> nightly-unstable/html/full-width-002.htm
> >
> > http://test.csswg.org/suites/css-writing-modes-3_dev/
> nightly-unstable/html/reference/full-width-horizontal-notref.htm
> >
> > I am wondering if the mismatching reference
> > full-width-horizontal-notref is relevant or necessary here.
> >
> > If and since text-combine-upright property "only has an effect in
> > vertical writing modes", then full-width-horizontal-notref does not
> > seem to me to be usefulness as a mismatch of full-width-002 test.
> >
> > On the other hand, as a test verifying that text-combine-upright
> > property "only has an effect in vertical writing modes", yes,
> > full-width-horizontal-notref would be useful.
>
>
> Masataka,
>
> http://test.csswg.org/suites/css-writing-modes-3_dev/
> nightly-unstable/html/reference/full-width-horizontal-notref.htm
>
> line 7: <style>
> line 8: .tcu-all {
> line 9:   text-combine-upright: all;
> line 10: }
> line 11: </style>
> </head>
> <body>
>
> <p>Test passes if the following paragraphs are identical:</p>
>
> <div>
> line 18:  <p>６月<span class="tcu-all">19</span>日</p>
> line 19:  <p>６月<span class="tcu-all">19</span>日</p>
> </div>
>
>
> Proposed modifications
> ----------------------
>
> line 18:  <p>６月19日</p>
> line 19:  <p>６月19日</p>
>
> Lines 7 to 11 in that mismatching full-width-horizontal-notref file
> would be removed. That way, non-vertical-writing-mode-aware browsers and
> non-vertical-writing-mode-capable browsers would fail the test.
>
> Gérard
> --
> Test Format Guidelines
> http://testthewebforward.org/docs/test-format-guidelines.html
>
> Test Style Guidelines
> http://testthewebforward.org/docs/test-style-guidelines.html
>
> Test Templates
> http://testthewebforward.org/docs/test-templates.html
>
> CSS Naming Guidelines
> http://testthewebforward.org/docs/css-naming.html
>
> Test Review Checklist
> http://testthewebforward.org/docs/review-checklist.html
>
> CSS Metadata
> http://testthewebforward.org/docs/css-metadata.html
>

Received on Monday, 17 November 2014 14:22:21 UTC