Re: 54 new tests submitted in section 3.1

Hi Gérard,

I have reviewed the following test.
 - block-flow-direction-001.xht ~ block-flow-direction-022.xht
 - line-box-direction-001.xht ~ line-box-direction-020.xht

Here is comments for these test.

1.
Some test-cases specify another specification's ref-file
(/css-multicol-1/multicol-count-002-ref.xht) as its ref-file.
I think that it is better to make a new ref-file (or copy) in
css-writing-modes-3 directory.

2.
All test-case uses 'yellow' and 'black' color.
I think that it is better to use 'green' and 'blue' because these makes
positive impression.

3.
I think that it is better to add information to title in some test-case.

- block-flow-direction-005.xht, block-flow-direction-006.xht
before: CSS Writing Modes Test: float and 'vertical-rl' - block flow
direction of block-level boxes
after: CSS Writing Modes Test: float*-left* and 'vertical-rl' - block flow
direction of block-level boxes

- block-flow-direction-007.xht, block-flow-direction-007.xht
before: CSS Writing Modes Test: float and 'vertical-lr' - block flow
direction of block-level boxes
after: CSS Writing Modes Test: float*-right* and 'vertical-lr' - block flow
direction of block-level boxes

- line-box-direction-005.xht, line-box-direction-006.xht
before: CSS Writing Modes Test: float and 'vertical-rl' - ordering
direction of line boxes
after: CSS Writing Modes Test: float*-left* and 'vertical-rl' - ordering
direction of line boxes

- line-box-direction-007.xht, line-box-direction-008.xht
before: CSS Writing Modes Test: float and 'vertical-lr' - ordering
direction of line boxes
after: CSS Writing Modes Test: float*-right* and 'vertical-lr' - ordering
direction of line boxes

4.
There is not line-box-direction-*004*.xht. Why is this missing?

During this weekend, I will review other test-case which you submitted.

Hajime.


2014-12-19 15:31 GMT+09:00 Gérard Talbot <css21testsuite@gtalbot.org>:

> Le 2014-12-17 08:38, Koji Ishii a écrit :
>
>  How long do you think it’ll take until you submit?
>>
>
> Done.
>
> committed changeset 6935:a4b95a324593 22 tests (18 new tests)
> committed changeset 6936:65afcff4b06b
> committed changeset 6937:912ef3c7b408 (block-flow-direction-023)
> committed changeset 6938:ca6495d8b9df 29 tests
> committed changeset 6939:65b6d0358772 7 tests and 7 images
> committed changeset 6940:81f6362c4cb7 1 test and 3 images
>
> They are all here, submitted on december 18th:
>
> http://test.csswg.org/source/css-writing-modes-3/?C=M;O=D
>
> --------
>
> I have added 2 last-minute tests:
>
> http://test.csswg.org/source/css-writing-modes-3/block-
> flow-direction-023.xht
>
> which is a minor variant of block-flow-direction-003
>
> and
>
> http://test.csswg.org/source/css-writing-modes-3/form-
> controls-vert-rl-005.xht
>
> I now think that maybe I should create a block-flow-direction-024 which
> would be a minor variant of block-flow-direction-002 to balance things...
>
> --------
>
> One last thing I need to check with Peter Linss.
>
> Shepherd is able to detect that the link target in the Public spec has
> been changed in the Editor’s Draft. So, that means
>
> http://www.w3.org/TR/css-writing-modes-3/#writing-mode
> is pointing to section 3.1 but, in the Editors' draft, it is now
> http://dev.w3.org/csswg/css-writing-modes-3/#block-flow
>
> I think Shepherd is only notifying me, informing me of such thing .... I
> do not think I need to change the actual, current
> <link rel="help" href="http://www.w3.org/TR/css-writing-modes-3/#writing-
> mode" title="3.1 Block Flow Direction: the writing-mode property" />
>
> ---------
>
>
>  I have not managed
>> yet but probably either Elika, Hajime, and/or I are the best
>> candidates to review them. Should we wait for the submission and
>> review on Shepherd, or would it help you if we review earlier on your
>> site?
>>
>
> Please wait that the tonight (00:00 Pacific Day Time) build process works
> and does not break!
>
> You can review those 58 tests after that in emails in the Public CSS Test
> suite mailing list or in Shepherd.
>
> My site is acting like an /incoming folder, like a transitory place where
> draft tests are standing by. So, those tests may not be ready.
>
> Gérard
> --
> Test Format Guidelines
> http://testthewebforward.org/docs/test-format-guidelines.html
>
> Test Style Guidelines
> http://testthewebforward.org/docs/test-style-guidelines.html
>
> Test Templates
> http://testthewebforward.org/docs/test-templates.html
>
> CSS Naming Guidelines
> http://testthewebforward.org/docs/css-naming.html
>
> Test Review Checklist
> http://testthewebforward.org/docs/review-checklist.html
>
> CSS Metadata
> http://testthewebforward.org/docs/css-metadata.html
>



-- 
# 塩澤 元 (Shiozawa, Hajime)
# mail: hajime.shiozawa@gmail.com