W3C home > Mailing lists > Public > public-css-testsuite@w3.org > December 2014

Re: [css-grid] grid-vertical-align-001 and grid-inline-vertical-align-001: review request

From: Manuel Rego Casasnovas <rego@igalia.com>
Date: Wed, 10 Dec 2014 11:29:30 +0100
Message-ID: <5488208A.7090507@igalia.com>
To: Gérard Talbot <css21testsuite@gtalbot.org>
CC: Public CSS Test suite mailing list <public-css-testsuite@w3.org>
Hi,

On 09/12/14 19:52, Gérard Talbot wrote:
> If you want to perfect your CSS code...
> 
> Class is (best used) for logical grouping of elements; id is for
> document-unique elements. So,
> 
> 
>             .test-grid-overlapping-green {
>                 display: grid;
>                 font: 50px/1 Ahem;
>                 color: green;
>             }
> 
>             .vertical-align {
>                 vertical-align: 125px;
>             }
> 
> (...)
> 
>         <div class="test-grid-overlapping-green">
>             <span>1s</span>
>             <span class="vertical-align">2n</span>
>         </div>
> 
> can be replaced with id in grid-vertical-align-001 and
> grid-inline-vertical-align-001 tests .

Yeah, I've fixed it and upload the tests adding you as reviewer.

> Later, you will need to get one of the spec editors to check at least a
> minority of your tests because I am not familiar with the grid spec. I
> can review the other aspects (like format, filename, text assert,
> possible pitfalls, etc.) of your tests.

At least for current tests your help is being really useful.
But I agree that It'd be great that someone familiar with the grid spec
take a look to the tests too.

Thanks,
  Rego
Received on Wednesday, 10 December 2014 10:29:54 UTC

This archive was generated by hypermail 2.3.1 : Tuesday, 6 January 2015 21:13:27 UTC